Uh oh!
There was an error while loading. Please reload this page.
acc: Improve testserver pipelines; add update test local+cloud - #2937
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersMay 23, 2025 14:10
pietern
approved these changes
May 26, 2025
| [[Repls]] | ||
| Old = '174\d{10}' | ||
| New = '[TIMESTAMP_MS]' |
Contributor
There was a problem hiding this comment.
This looks like a globally useful replacement. WDYT?
ContributorAuthor
There was a problem hiding this comment.
Seems like it, we should merge it with this one:
bundle/templates/telemetry/custom-template/out.requests.txt- "body": {
bundle/templates/telemetry/custom-template/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
bundle/templates/telemetry/dbt-sql/out.requests.txt- "body": {
bundle/templates/telemetry/dbt-sql/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
bundle/templates/telemetry/default-python/out.requests.txt- "body": {
bundle/templates/telemetry/default-python/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
bundle/templates/telemetry/default-sql/out.requests.txt- "body": {
bundle/templates/telemetry/default-sql/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
bundle/templates/telemetry/test.toml-Old = '17\d{11}'
bundle/templates/telemetry/test.toml:New = '"UNIX_TIME_MILLIS"'
--
telemetry/failure/out.requests.txt- "body": {
telemetry/failure/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/failure/out.requests.txt- "body": {
telemetry/failure/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/failure/out.requests.txt- "body": {
telemetry/failure/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/failure/output.txt-> ],
telemetry/failure/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/failure/output.txt-> ],
telemetry/failure/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/failure/output.txt-> ],
telemetry/failure/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/partial-success/out.requests.txt- "body": {
telemetry/partial-success/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/partial-success/out.requests.txt- "body": {
telemetry/partial-success/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/partial-success/out.requests.txt- "body": {
telemetry/partial-success/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/partial-success/output.txt-> ],
telemetry/partial-success/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/partial-success/output.txt-> ],
telemetry/partial-success/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/partial-success/output.txt-> ],
telemetry/partial-success/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/success/out.requests.txt- "body": {
telemetry/success/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/success/output.txt-> ],
telemetry/success/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
--
telemetry/test.toml-Old = '17\d{11}'
telemetry/test.toml:New = '"UNIX_TIME_MILLIS"'
--
telemetry/timeout/out.requests.txt- "body": {
telemetry/timeout/out.requests.txt: "uploadTime": "UNIX_TIME_MILLIS",
--
telemetry/timeout/output.txt-> ],
telemetry/timeout/output.txt:> "uploadTime": "UNIX_TIME_MILLIS"
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes - Update testserver pipeline to populate fields same way as real server does it. - Add new pipeline server that exercises Create and Update. - Add new script read_id.py to get id from the state. ## Why Using this test in #2926 ## Tests New acceptance local + integration test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Using this test in #2926
Tests
New acceptance local + integration test.