Uh oh!
There was an error while loading. Please reload this page.
Simplify cmd/bundle/{summary,validate}.go - #3182
Merged
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJuly 4, 2025 12:48
Collaborator
12 failing tests:
|
| return nil | ||
| default: | ||
| return fmt.Errorf("unknown output type %s", root.OutputType(cmd)) |
Contributor
There was a problem hiding this comment.
Don't we want to keep this default error?
ContributorAuthor
There was a problem hiding this comment.
output type is validated to be text or json, so that line should never be reachable.
| if root.OutputType(cmd) == flags.OutputText { | ||
| err = render.RenderDiagnostics(cmd.OutOrStdout(), b, diags, render.RenderOptions{RenderSummaryTable: false}) | ||
| } else { | ||
| err = render.RenderDiagnostics(cmd.OutOrStderr(), b, diags, render.RenderOptions{RenderSummaryTable: false}) |
Contributor
There was a problem hiding this comment.
The call in if and else conditions are the same, should there be RenderSummaryTable: true somewhere?
ContributorAuthor
There was a problem hiding this comment.
It's not the same: stderr for json, stdout for test.
Contributor
There was a problem hiding this comment.
Oh right, it was difficult to spot
andrewnester
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The common function added in #3123 make it harder to understand what's going on and I removed it in #3175
Sending this as separate PR to make #3175 easier to review.