Uh oh!
There was an error while loading. Please reload this page.
Fix #3109: default search location for whl artifacts - #3184
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJuly 7, 2025 08:24
denik
enabled auto-merge
July 7, 2025 08:36
Collaborator
16 failing tests:
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
shreyas-goenka
approved these changes
Jul 7, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Jul 7, 2025
denik added a commit
that referenced
this pull request
Jul 7, 2025
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jul 10, 2025
## Release v0.259.0 ### Notable Changes * Add support for arbitrary scripts in DABs. Users can now define scripts in their bundle configuration. These scripts automatically inherit the bundle's credentials for authentication. They can be invoked with the `bundle run` command. ([#2813](#2813)) * Error when the absolute path to `databricks.yml` contains a glob character. These are: `*`, `?`, `[`, `]` and `^`. If the path to the `databricks.yml` file on your local filesystem contains one of these characters, that could lead to incorrect computation of glob patterns for the `includes` block and might cause resources to be deleted. After this patch users will not be at risk for unexpected deletions due to this issue. ([#3096](#3096)) * Diagnostics messages are no longer buffered to be printed at the end of command, flushed after every mutator ([#3175](#3175)) * Diagnostics are now always rendered with forward slashes in file paths, even on Windows ([#3175](#3175)) * "bundle summary" now prints diagnostics to stderr instead of stdout in text output mode ([#3175](#3175)) * "bundle summary" no longer prints recommendations, it will only prints warnings and errors ([#3175](#3175)) ### Bundles * Fix default search location for whl artifacts ([#3184](#3184)). This was a regression introduced in 0.255.0. * The job tasks are now sorted by task key in "bundle validate/summary" output ([#3212](#3212))
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes When initializing `artifacts.*.files.source` to default `<Path>/dist/*.whl` we used to (in version 0.254.0 and earlier) first to initialize path to bundle root then join it with "dist/*.whl". After #2987 we switched to first initializing Files.Source then initializing Path, thus breaking some cases, see #3109 ## Tests New acceptance regression test, reproduces #3109 without this PR ebffb67
denik added a commit
that referenced
this pull request
May 20, 2026
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.259.0 ### Notable Changes * Add support for arbitrary scripts in DABs. Users can now define scripts in their bundle configuration. These scripts automatically inherit the bundle's credentials for authentication. They can be invoked with the `bundle run` command. ([#2813](#2813)) * Error when the absolute path to `databricks.yml` contains a glob character. These are: `*`, `?`, `[`, `]` and `^`. If the path to the `databricks.yml` file on your local filesystem contains one of these characters, that could lead to incorrect computation of glob patterns for the `includes` block and might cause resources to be deleted. After this patch users will not be at risk for unexpected deletions due to this issue. ([#3096](#3096)) * Diagnostics messages are no longer buffered to be printed at the end of command, flushed after every mutator ([#3175](#3175)) * Diagnostics are now always rendered with forward slashes in file paths, even on Windows ([#3175](#3175)) * "bundle summary" now prints diagnostics to stderr instead of stdout in text output mode ([#3175](#3175)) * "bundle summary" no longer prints recommendations, it will only prints warnings and errors ([#3175](#3175)) ### Bundles * Fix default search location for whl artifacts ([#3184](#3184)). This was a regression introduced in 0.255.0. * The job tasks are now sorted by task key in "bundle validate/summary" output ([#3212](#3212))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When initializing
artifacts.*.files.sourceto default<Path>/dist/*.whlwe used to (in version 0.254.0 and earlier) first to initialize path to bundle root then join it with "dist/*.whl". After #2987 we switched to first initializing Files.Source then initializing Path, thus breaking some cases, see #3109Tests
New acceptance regression test, reproduces #3109 without this PR ebffb67