Uh oh!
There was an error while loading. Please reload this page.
acc: Clean up unnecessary replacements - #3195
Merged
Merged
Conversation
Collaborator
|
denikforce-pushed
the
denik/cleanup-slashes-repls
branch
from
July 8, 2025 14:34
a3fc7fe to
c5ade2fComparedenik
marked this pull request as ready for review
July 8, 2025 14:50
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJuly 8, 2025 14:50
shreyas-goenka
approved these changes
Jul 8, 2025
denikforce-pushed
the
denik/cleanup-slashes-repls
branch
from
July 8, 2025 15:44
c5ade2f to
fc7b63cCompareUh oh!
There was an error while loading. Please reload this page.
shreyas-goenka pushed a commit
that referenced
this pull request
Jul 9, 2025
shreyas-goenka added a commit
that referenced
this pull request
Jul 10, 2025
## Changes Reverts: #3195 ## Why These tests started failing because of the missing repl. Diff: ``` ->>> cp [TESTROOT]/bundle/resources/clusters/run/spark_python_task/../../deploy/simple/hello_world.py . +>>> cp [TESTROOT]\bundle\resources\clusters\run\spark_python_task/../../deploy/simple/hello_world.py . ```
denik added a commit
that referenced
this pull request
May 20, 2026
Since #3175 the diagnostics are rendered with forward slashes on Windows.
denik added a commit
that referenced
this pull request
May 20, 2026
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Reverts: #3195 ## Why These tests started failing because of the missing repl. Diff: ``` ->>> cp [TESTROOT]/bundle/resources/clusters/run/spark_python_task/../../deploy/simple/hello_world.py . +>>> cp [TESTROOT]\bundle\resources\clusters\run\spark_python_task/../../deploy/simple/hello_world.py . ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #3175 the diagnostics are rendered with forward slashes on Windows.