Uh oh!
There was an error while loading. Please reload this page.
pipelines: update deploy.go and add fail-on-active-runs flag - #3235
Conversation
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jefferycheng1
left a comment
There was a problem hiding this comment.
let's add tests for this, should be straightforward!
kanterov
left a comment
There was a problem hiding this comment.
Please review with Andrew/Denis. Also what about acceptance tests?
| @@ -1,3 +1,5 @@ | |||
| // Copied to cmd/pipelines/deploy.go and adapted for pipelines use. | |||
There was a problem hiding this comment.
Not sure if we need the comment here though
There was a problem hiding this comment.
is there another way you would suggest? @jefferycheng1 and I were discussing how to standardize these comments in the future, as we do want changes made to deploy.go to be considered for pipelines as well.
There was a problem hiding this comment.
@andrewnester I thought to keep this in for posterity. tbh, I'm not sure how helpful this will be though, given how few people work on this, but it at least reminds PR authors to consider it. When we move pipelines out, we can remove this altogether. thoughts?
c0866c4 to
00f022fCompareUh oh!
There was an error while loading. Please reload this page.
## Changes Synchronize deploy.go to cmd/bundle/deploy.go and add new `fail-on-active-runs` flag ## Why New flag is for controlling that pipelines deploy fails when the pipeline is currently running ## Tests Added pipeline specific test that causes deploy to fail when pipeline is running and `fail-on-active-runs` is set
Changes
Synchronize deploy.go to cmd/bundle/deploy.go and add new
fail-on-active-runsflagWhy
New flag is for controlling that pipelines deploy fails when the pipeline is currently running
Tests
Added pipeline specific test that causes deploy to fail when pipeline is running and
fail-on-active-runsis set