Uh oh!
There was an error while loading. Please reload this page.
Change execv to use current directory as a working directory if no directory is provided - #3267
Merged
Merged
Conversation
…rectory is provided
anton-107
marked this pull request as ready for review
July 17, 2025 15:39
anton-107
requested review from
andrewnester, denik, pietern and shreyas-goenka
as code ownersJuly 17, 2025 15:39
Collaborator
|
shreyas-goenka
approved these changes
Jul 18, 2025
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Jul 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
denik pushed a commit
that referenced
this pull request
May 20, 2026
…rectory is provided (#3267) ## Why <!-- Why are these changes needed? Provide the context that the reviewer might be missing. For example, were there any decisions behind the change that are not reflected in the code itself? --> This is a follow-up for the comment in the previous PR #3128 : #3128 (comment) ## Tests <!-- How have you tested the changes? --> - Existing acceptance test on cmd/psql is still passing even though the production code is not specifying a directory - Manually checked that when executed with `pwd` the process prints current working directory on Mac and on Windows <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is a follow-up for the comment in the previous PR #3128 : #3128 (comment)
Tests
pwdthe process prints current working directory on Mac and on Windows