Uh oh!
There was an error while loading. Please reload this page.
Always set default value for source field for tasks if not explicitly set already - #3359
Conversation
13 failing tests:
|
Did you mean "if the job has git_source set"? |
andrewnester
commented
Aug 5, 2025
I meant |
| task_key: test_task_foreach_workspace | ||
| notebook_task: | ||
| notebook_path: ./notebook.py | ||
| source: WORKSPACE |
There was a problem hiding this comment.
question -- should we also test "source: GIT" here? Can job/tasks mix different sources?
There was a problem hiding this comment.
It can, hence me adding source:Workspace here. But what would setting source: GIT will give for this job if it's default value anyway anyway?
We can't have source: GIT on non Git jobs so that's why no tests for this
There was a problem hiding this comment.
I missed the fact there is job-level git_source setting.
Testing both implicit default and explicit value even if equal to default could be useful but not required.
We can't have source: GIT on non Git jobs so that's why no tests for this
This might be out of scope of this PR but testing wrong configuration to record error message is useful to test assumptions and ensure errors look good.
| dyn.Key("resources"), | ||
| dyn.Key("jobs"), | ||
| dyn.AnyKey(), | ||
| ) |
There was a problem hiding this comment.
general question - should this variables be globals? They carry no state and can be initialized once.
There was a problem hiding this comment.
I don't think there's a practical difference since this mutator is called only once anyway but I have no concern with making it global either
There was a problem hiding this comment.
For context, mutators can be called multiple times - for static and "python" resources.
| task_key: test_task_foreach_workspace | ||
| notebook_task: | ||
| notebook_path: ./notebook.py | ||
| source: WORKSPACE |
There was a problem hiding this comment.
I missed the fact there is job-level git_source setting.
Testing both implicit default and explicit value even if equal to default could be useful but not required.
We can't have source: GIT on non Git jobs so that's why no tests for this
This might be out of scope of this PR but testing wrong configuration to record error message is useful to test assumptions and ensure errors look good.
| func setSourceIfNotSet(task dyn.Value, defaultSource string) (dyn.Value, error) { | ||
| for _, taskType := range supportedTypeTasks { | ||
| t, err := dyn.Get(task, taskType) |
There was a problem hiding this comment.
Question, not a request - Why prefer dyn value over struct here?
There was a problem hiding this comment.
No particular reason, but I prefer to make mutative operations on dynamic config and non-mutative ones on static ones, so that there's a clear distinction between using both
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
## Release v0.263.0 ### CLI * Show "DEFAULT" as the default profile for `databricks auth login` [#3252](#3252) ### Bundles * Always set default value for source field for tasks if not explicitly set already ([#3359](#3359)) * Fix panic in auto completion handler for bundler run/open. Regression introduced in 0.259.0. [#3358](#3358) * Fix error propagation in the `bundle generate dashboard` command. Regression introduced in 0.259.0. [#3354](#3354)
… set already (#3359) ## Changes If the job has `git_source` set, DABs will set `source: GIT` to all the tasks where source is not already set If the job has no `git_source` set, DABs will set `source: WORKSPACE` to all the tasks where source is not already set We only do this for a subset of task types which support source field as per https://docs.databricks.com/api/workspace/jobs/create ## Why Fixes#2561 ## Tests Added an acceptance test <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
## Release v0.263.0 ### CLI * Show "DEFAULT" as the default profile for `databricks auth login` [#3252](#3252) ### Bundles * Always set default value for source field for tasks if not explicitly set already ([#3359](#3359)) * Fix panic in auto completion handler for bundler run/open. Regression introduced in 0.259.0. [#3358](#3358) * Fix error propagation in the `bundle generate dashboard` command. Regression introduced in 0.259.0. [#3354](#3354)
… set already (#3359) ## Changes If the job has `git_source` set, DABs will set `source: GIT` to all the tasks where source is not already set If the job has no `git_source` set, DABs will set `source: WORKSPACE` to all the tasks where source is not already set We only do this for a subset of task types which support source field as per https://docs.databricks.com/api/workspace/jobs/create ## Why Fixes#2561 ## Tests Added an acceptance test <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
## Release v0.263.0 ### CLI * Show "DEFAULT" as the default profile for `databricks auth login` [#3252](#3252) ### Bundles * Always set default value for source field for tasks if not explicitly set already ([#3359](#3359)) * Fix panic in auto completion handler for bundler run/open. Regression introduced in 0.259.0. [#3358](#3358) * Fix error propagation in the `bundle generate dashboard` command. Regression introduced in 0.259.0. [#3354](#3354)
Changes
If the job has
git_sourceset, DABs will setsource: GITto all the tasks where source is not already setIf the job has no
git_sourceset, DABs will setsource: WORKSPACEto all the tasks where source is not already setWe only do this for a subset of task types which support source field as per https://docs.databricks.com/api/workspace/jobs/create
Why
Fixes#2561
Tests
Added an acceptance test