Skip to content

Remove unused skipFn in variable resolution mutator - #3366

Merged
denik merged 1 commit into
mainfrom
denik/remove-skip-fn
Aug 6, 2025
Merged

Remove unused skipFn in variable resolution mutator#3366
denik merged 1 commit into
mainfrom
denik/remove-skip-fn

Conversation

@denik

@denikdenik commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Usage removed in #2157
Added in #1467

@denik
deniktemporarily deployed to test-trigger-is August 6, 2025 10:36 — with GitHub Actions Inactive
@denik
denikforce-pushed the denik/remove-skip-fn branch from 01ad174 to 330a6e2CompareAugust 6, 2025 10:39
@denik
deniktemporarily deployed to test-trigger-is August 6, 2025 10:39 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 6, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Run: 16774632156

Env✅‌pass❌‌FAIL🔄‌flaky🙈‌skip
🔄‌aws linux3054460
🔄‌aws windows3064459
❌‌aws-ucws linux41032360
🔄‌aws-ucws windows4133359
🔄‌azure linux3018459
🔄‌azure windows3046458
🔄‌azure-ucws linux4089357
❌‌azure-ucws windows39028356
🔄‌gcp linux3044461
🔄‌gcp windows3072460
40 failing tests:
Test Nameaws linuxaws windowsaws-ucws linuxaws-ucws windowsazure linuxazure windowsazure-ucws linuxazure-ucws windowsgcp linuxgcp windows
TestAccept✅‌pass✅‌pass❌‌FAIL🔄‌flaky✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass
TestAccept/bundle/deploy/files/no-snapshot-sync/DATABRICKS_CLI_DEPLOYMENT=direct-exp✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass
TestAccept/bundle/deploy/pipeline/allow-duplicate-names✅‌pass🔄‌flaky❌‌FAIL🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky❌‌FAIL🔄‌flaky✅‌pass
TestAccept/bundle/deploy/pipeline/allow-duplicate-names/DATABRICKS_CLI_DEPLOYMENT=direct-exp✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/deploy/pipeline/allow-duplicate-names/DATABRICKS_CLI_DEPLOYMENT=terraform✅‌pass🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky❌‌FAIL🔄‌flaky✅‌pass
TestAccept/bundle/deploy/volume/recreate🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/deployment/bind/dashboard✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass
TestAccept/bundle/resources/pipelines/update✅‌pass✅‌pass🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky✅‌pass✅‌pass🔄‌flaky✅‌pass
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=direct-exp🔄‌flaky🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky
TestAccept/bundle/resources/pipelines/update/DATABRICKS_CLI_DEPLOYMENT=terraform🔄‌flaky🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky✅‌pass✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/templates/default-python/combinations/classic✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=no/NBOOK=yes/PY=no✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=yes/NBOOK=no/PY=no✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_CLI_DEPLOYMENT=terraform/DLT=yes/NBOOK=no/PY=no✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/combinations/serverless✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=no/NBOOK=no/PY=yes🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=no/NBOOK=yes/PY=no🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip🔄‌flaky❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=no/NBOOK=yes/PY=yes🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=yes/NBOOK=no/PY=no🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=yes/NBOOK=no/PY=yes🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=direct-exp/DLT=yes/NBOOK=yes/PY=no🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=terraform/DLT=no/NBOOK=yes/PY=no🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/combinations/serverless/DATABRICKS_CLI_DEPLOYMENT=terraform/DLT=yes/NBOOK=yes/PY=yes🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/bundle/templates/default-python/integration_classic✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/UV_PYTHON=3.10✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=direct-exp/UV_PYTHON=3.12✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.10✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky❌‌FAIL✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.13✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.9✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/selftest/record_cloud/pipeline-crud✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_CLI_DEPLOYMENT=direct-exp✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/selftest/record_cloud/pipeline-crud/DATABRICKS_CLI_DEPLOYMENT=terraform✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/selftest/record_cloud/volume-io🙈‌skip🙈‌skip✅‌pass✅‌pass🙈‌skip🙈‌skip✅‌pass❌‌FAIL🙈‌skip🙈‌skip
TestAccept/selftest/record_cloud/volume-io/DATABRICKS_CLI_DEPLOYMENT=direct-exp✅‌pass✅‌pass✅‌pass❌‌FAIL
TestAccept/selftest/record_cloud/volume-io/DATABRICKS_CLI_DEPLOYMENT=terraform✅‌pass✅‌pass✅‌pass❌‌FAIL
TestAccept/selftest/record_cloud/workspace-file-io🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/selftest/record_cloud/workspace-file-io/DATABRICKS_CLI_DEPLOYMENT=direct-exp🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass❌‌FAIL✅‌pass✅‌pass
TestAccept/terraform✅‌pass✅‌pass✅‌pass✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass✅‌pass✅‌pass

@denik
denik enabled auto-merge August 6, 2025 11:16
@denik
denik disabled auto-merge August 6, 2025 11:20
@denik
denik merged commit 8797d0f into mainAug 6, 2025
12 of 13 checks passed
@denik
denik deleted the denik/remove-skip-fn branch August 6, 2025 11:20
alyssa-db pushed a commit that referenced this pull request Aug 7, 2025
@denik@alyssa-db
Remove unused skipFn in variable resolution mutator (#3366)
19acd22
Usage removed in #2157
Added in #1467
denik added a commit that referenced this pull request May 20, 2026
@denik
Remove unused skipFn in variable resolution mutator (#3366)
ffce604
Usage removed in #2157
Added in #1467
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreyas-goenkashreyas-goenkashreyas-goenka approved these changes
@pieternpieternAwaiting requested review from pietern
@andrewnesterandrewnesterAwaiting requested review from andrewnester
@anton-107anton-107Awaiting requested review from anton-107

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@denik@eng-dev-ecosystem-bot@shreyas-goenka