Uh oh!
There was an error while loading. Please reload this page.
Add enum for volume grant privileges - #3395
Merged
Merged
Conversation
kanterov
marked this pull request as ready for review
August 12, 2025 08:10
kanterovtemporarily deployed
to
test-trigger-is
August 12, 2025 08:10 — with 
GitHub Actions
Inactive
kanterov
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersAugust 12, 2025 08:10
kanterovtemporarily deployed
to
test-trigger-is
August 12, 2025 08:14 — with GitHub Actions
Inactive
Collaborator
19 failing tests:
|
kanterovtemporarily deployed
to
test-trigger-is
August 13, 2025 06:23 — with GitHub Actions
Inactive
kanterovtemporarily deployed
to
test-trigger-is
August 13, 2025 06:25 — with GitHub Actions
Inactive
6 tasks
pietern
approved these changes
Aug 13, 2025
| type VolumeGrantPrivilege string | ||
| const ( |
Contributor
There was a problem hiding this comment.
Can you also add the Values function for this type? That'll enable automatic enum validation:
Line 16 in dc55c62
CollaboratorAuthor
There was a problem hiding this comment.
TIL. Thanks, I will do
kanterovforce-pushed
the
volume-grant-privilege
branch
from
August 14, 2025 07:27
9dd4ed7 to
a909b3dComparekanterovtemporarily deployed
to
test-trigger-is
August 14, 2025 07:27 — with GitHub Actions
Inactive
kanterov
enabled auto-merge
August 14, 2025 07:36
Uh oh!
There was an error while loading. Please reload this page.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Add an enum for volume grant privileges. Possible values are: - `ALL_PRIVILEGES` - `APPLY_TAG` (missing in Terraform docs but supported) - `MANAGE` - `READ_VOLUME` - `WRITE_VOLUME` It follows documented privileges in Terraform documentation: https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants#volume-grants I will add `APPLY_TAG` to Terraform as a follow-up. ## Why Using enums gives better typing in JSON schema and allows generating enums in Python code ## Tests By inspecting the resulting JSON schema
denik pushed a commit
that referenced
this pull request
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add an enum for volume grant privileges.
Possible values are:
ALL_PRIVILEGESAPPLY_TAG(missing in Terraform docs but supported)MANAGEREAD_VOLUMEWRITE_VOLUMEIt follows documented privileges in Terraform documentation: https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grants#volume-grants
I will add
APPLY_TAGto Terraform as a follow-up.Why
Using enums gives better typing in JSON schema and allows generating enums in Python code
Tests
By inspecting the resulting JSON schema