Skip to content

Fix panic in auto-completion handler for pipelines run/open - #3408

Merged
shreyas-goenka merged 1 commit into
mainfrom
auto-completion-fix-0
Aug 13, 2025
Merged

Fix panic in auto-completion handler for pipelines run/open#3408
shreyas-goenka merged 1 commit into
mainfrom
auto-completion-fix-0

Conversation

@alyssa-db

@alyssa-dbalyssa-db commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Changes

Copying fix applied to autocompletion in bundle to pipelines run/open: #3358

Why

Before, cmd.ValidArgsFunction is not working properly, as in the terminal, Tab does not autocomplete the resource key.

databricks pipelines run ...

Now autocompletes with
databricks pipelines run resource-name

Tests

New acceptance tests that trigger completion handler for pipelines run/open.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 13, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Run: 16924176304

Env✅‌pass🔄‌flaky🙈‌skip
✅‌aws linux308468
✅‌aws windows309467
🔄‌aws-ucws linux40410368
🔄‌aws-ucws windows40510367
✅‌azure linux308467
🔄‌azure windows3054466
🔄‌azure-ucws linux40610365
🔄‌azure-ucws windows40710364
✅‌gcp linux307469
✅‌gcp windows308468
14 failing tests:
Test Nameaws-ucws linuxaws-ucws windowsazure windowsazure-ucws linuxazure-ucws windows
TestAccept✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass
TestAccept/bundle/deploy/dashboard/detect-change🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deploy/dashboard/generate_inplace🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deploy/dashboard/nested-folders🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_outside_bundle_root🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deploy/dashboard/simple_syncroot🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/deployment/bind/dashboard/recreation🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestAccept/bundle/templates/default-python/integration_classic✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_CLI_DEPLOYMENT=terraform/UV_PYTHON=3.10✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass
TestDashboardAssumptions_WorkspaceImport🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestFetchRepositoryInfoAPI_FromRepo🔄‌flaky🔄‌flaky✅‌pass🔄‌flaky🔄‌flaky
TestSyncNestedSpacePlusAndHashAreEscapedSync✅‌pass✅‌pass🔄‌flaky✅‌pass✅‌pass

@andrewnester
andrewnester added this pull request to the merge queueAug 13, 2025
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Aug 13, 2025
@shreyas-goenka
shreyas-goenka added this pull request to the merge queueAug 13, 2025
Merged via the queue into main with commit ad058edAug 13, 2025
22 of 23 checks passed
@shreyas-goenka
shreyas-goenka deleted the auto-completion-fix-0 branch August 13, 2025 13:46
denik pushed a commit that referenced this pull request May 20, 2026
@alyssa-db
Fix panic in auto-completion handler for pipelines run/open (#3408)
b56748f
## Changes
Copying fix applied to autocompletion in bundle to pipelines run/open:
#3358
## Why
Before, cmd.ValidArgsFunction is not working properly, as in the
terminal, Tab does not autocomplete the resource key.
databricks pipelines run ... Now autocompletes with
databricks pipelines run resource-name
## Tests
New acceptance tests that trigger completion handler for pipelines
run/open.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jefferycheng1jefferycheng1jefferycheng1 approved these changes
@kanterovkanterovAwaiting requested review from kanterov
@lennartkats-dblennartkats-dbAwaiting requested review from lennartkats-db

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alyssa-db@eng-dev-ecosystem-bot@jefferycheng1@shreyas-goenka