Uh oh!
There was an error while loading. Please reload this page.
acc: Convert artifacts_test and upload_test into acceptance tests - #3477
Merged
Conversation
andrewnester
requested review from
anton-107, denik, pietern and shreyas-goenka
as code ownersAugust 25, 2025 13:56
andrewnestertemporarily deployed
to
test-trigger-is
August 25, 2025 13:56 — with 
GitHub Actions
Inactive
andrewnester
enabled auto-merge
August 25, 2025 13:59
Collaborator
|
denik
reviewed
Aug 25, 2025
| @@ -0,0 +1 @@ | |||
| *.whl | |||
Contributor
There was a problem hiding this comment.
what's the purpose of this .gitignore, how does it affect this test?
Why does it upload anything? Because libraries setting overrides gitignore?
ContributorAuthor
There was a problem hiding this comment.
Left over from the other iteration, we indeed don't need it here
andrewnestertemporarily deployed
to
test-trigger-is
August 25, 2025 15:01 — with GitHub Actions
Inactive
andrewnestertemporarily deployed
to
test-trigger-is
August 25, 2025 15:06 — with GitHub Actions
Inactive
denik
approved these changes
Aug 25, 2025
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Aug 26, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
denik pushed a commit
that referenced
this pull request
May 20, 2026
) ## Changes Convert artifacts_test and upload_test into acceptance tests ## Why Needed for #3442 <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Convert artifacts_test and upload_test into acceptance tests
Why
Needed for #3442