Uh oh!
There was an error while loading. Please reload this page.
Fix structaccess.Get to handle embedded structs and empty slices/maps - #3657
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersSeptember 25, 2025 08:52
deniktemporarily deployed
to
test-trigger-is
September 25, 2025 08:52 — with
GitHub Actions
Inactive
Collaborator
|
deniktemporarily deployed
to
test-trigger-is
September 25, 2025 09:10 — with
GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 25, 2025 10:46 — with
GitHub Actions
Inactive
andrewnester
approved these changes
Sep 25, 2025
denikforce-pushed
the
denik/structaccess-get-fsf
branch
from
September 25, 2025 12:14
9297462 to
c14f9e6Comparedeniktemporarily deployed
to
test-trigger-is
September 25, 2025 12:14 — with
GitHub Actions
Inactive
deniktemporarily deployed
to
test-trigger-is
September 25, 2025 12:16 — with
GitHub Actions
Inactive
denik
enabled auto-merge
September 25, 2025 12:19
denikforce-pushed
the
denik/structaccess-get-fsf
branch
from
September 25, 2025 12:25
5280d2c to
0f21130Comparedeniktemporarily deployed
to
test-trigger-is
September 25, 2025 12:25 — with
GitHub Actions
Inactive
denik
disabled auto-merge
September 25, 2025 12:31
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixing bugs, this is used in direct deployment for resolving resource references.
Tests are adapted from #3650 it's the same issue in different libraries.
Tests
New unit tests.