Uh oh!
There was an error while loading. Please reload this page.
Include skip actions in JSON plan - #3663
Merged
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersSeptember 25, 2025 14:00
denikforce-pushed
the
denik/include-skip-action
branch
from
September 25, 2025 14:02
7d9b949 to
18d1d32Comparedeniktemporarily deployed
to
test-trigger-is
September 25, 2025 14:02 — with 
GitHub Actions
Inactive
pietern
approved these changes
Sep 25, 2025
Uh oh!
There was an error while loading. Please reload this page.
Collaborator
|
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes Include 'skip' nodes in JSON plan. ## Why We need to process 'skip' resources as well (e.g. to resolve references). Today, we have these nodes in the graph but not in the plan. Once we move to serialized plan #3636 we will build graph from the plan so they must match. This prepares for that (and minimizes that PR). This also gives more information to users of JSON plan, e.g. they can count unchanged count. ## Tests Existing tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Include 'skip' nodes in JSON plan.
Why
We need to process 'skip' resources as well (e.g. to resolve references). Today, we have these nodes in the graph but not in the plan. Once we move to serialized plan #3636 we will build graph from the plan so they must match. This prepares for that (and minimizes that PR).
This also gives more information to users of JSON plan, e.g. they can count unchanged count.
Tests
Existing tests.