Uh oh!
There was an error while loading. Please reload this page.
Change ruff line-length setting to 120 - #3675
Merged
Merged
Conversation
lennartkats-db
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersSeptember 29, 2025 08:44
lennartkats-dbtemporarily deployed
to
test-trigger-is
September 29, 2025 08:44 — with 
GitHub Actions
Inactive
Collaborator
11 failing tests:
|
shreyas-goenka
approved these changes
Sep 29, 2025
lennartkats-db
requested review from
jefferycheng1 and kanterov
as code ownersSeptember 29, 2025 11:19
Resolve merge conflicts in Python template files by adopting single-line formatting with f-strings from main branch to align with 120-character line length goal. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-dbtemporarily deployed
to
test-trigger-is
September 30, 2025 09:57 — with GitHub Actions
Inactive
lennartkats-db
enabled auto-merge
September 30, 2025 10:01
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 12, 2026
## Changes This switches the code formatter to ruff and sets the line length to 120 a described in #3675. ## Why * ruff mindshare, performance, and ability to combine linting and formatting ## Tests * Standard acceptance tests --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This changes the ruff formatter line-length from 150 to 120. ## Why 120 * PEP8 line length is 79 ← _this is extremely tight_ * Black and Ruff default line length is 88 ← _this is good since it's a tooling default but, still rather tight_ * Current line length was 150 to balance line length vs. spreading code over many lines * The [workspace formatter](https://docs.databricks.com/aws/en/notebooks/notebooks-code#python-black-formatter-library) defaults to 120 ← _this seems like a sweet spot for us; it means our templates by default use the same setting as the workspace_ Note that for IDE support of our templates, we could set a `tool.black` section as done in https://github.com/databricks/cli/pull/3671/files?w=1#diff-ed1a9755eebbb3b630edc93a5731f9dd8caa66b9967f9a57234c6ce9bde88c33R25-R26. Doing that is out of scope for the present PR. ## Tests Standard acceptance tests. --------- Co-authored-by: Claude <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This switches the code formatter to ruff and sets the line length to 120 a described in #3675. ## Why * ruff mindshare, performance, and ability to combine linting and formatting ## Tests * Standard acceptance tests --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This changes the ruff formatter line-length from 150 to 120.
Why 120
Note that for IDE support of our templates, we could set a
tool.blacksection as done in https://github.com/databricks/cli/pull/3671/files?w=1#diff-ed1a9755eebbb3b630edc93a5731f9dd8caa66b9967f9a57234c6ce9bde88c33R25-R26. Doing that is out of scope for the present PR.Tests
Standard acceptance tests.