Uh oh!
There was an error while loading. Please reload this page.
Add template_dir support to template schema - #3686
Merged
Merged
Conversation
lennartkats-db
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersSeptember 30, 2025 12:28
lennartkats-dbtemporarily deployed
to
test-trigger-is
September 30, 2025 12:28 — with 
GitHub Actions
Inactive
This allows template schemas to reference template files from a different directory using the template_dir property. This enables schema sharing between templates while keeping their template files separate. Changes: - Add TemplateDir field to jsonschema.Extension - Update template readers to support template_dir resolution - Modify template writer to use new LoadSchemaAndTemplateFS interface - Add comprehensive tests for template_dir functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
lennartkats-dbforce-pushed
the
project-dir-setting
branch
from
September 30, 2025 12:31
ad74144 to
04ceaebComparelennartkats-dbtemporarily deployed
to
test-trigger-is
September 30, 2025 12:31 — with GitHub Actions
Inactive
Collaborator
|
shreyas-goenka
left a comment
Contributor
There was a problem hiding this comment.
Overall the changes look good to me, other than the missing test. What's the usecase though?
Uh oh!
There was an error while loading. Please reload this page.
shreyas-goenka
self-requested a review
October 1, 2025 09:50
shreyas-goenka
approved these changes
Oct 1, 2025
Uh oh!
There was an error while loading. Please reload this page.
denik pushed a commit
that referenced
this pull request
May 20, 2026
This allows template schemas to reference template files from a different directory using the template_dir property. This enables schema sharing between templates while keeping their template files separate. ## Changes - Add TemplateDir field to jsonschema.Extension - Update template readers to support template_dir resolution - Modify template writer to use new LoadSchemaAndTemplateFS interface - Add comprehensive tests for template_dir functionality 🤖 Extracted from #3671 with [Claude Code](https://claude.ai/code) ## Tests * Standard unit tests, acceptance tests in #3671 --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows template schemas to reference template files from a different directory using the template_dir property. This enables schema sharing between templates while keeping their template files separate.
Changes
🤖 Extracted from #3671 with Claude Code
Tests