Uh oh!
There was an error while loading. Please reload this page.
direct: refactor models test; record API requests - #3705
Closed
shreyas-goenka wants to merge 5 commits into
Closed
Conversation
shreyas-goenkatemporarily deployed
to
test-trigger-is
October 1, 2025 17:12 — with 
GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
October 1, 2025 17:17 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
October 1, 2025 17:28 — with GitHub Actions
Inactive
shreyas-goenka
marked this pull request as ready for review
October 1, 2025 17:31
shreyas-goenka
requested review from
andrewnester, anton-107, denik and pietern
as code ownersOctober 1, 2025 17:31
Collaborator
|
shreyas-goenkatemporarily deployed
to
test-trigger-is
October 1, 2025 21:01 — with GitHub Actions
Inactive
denik
reviewed
Oct 24, 2025
| } | ||
| } | ||
| { | ||
| "method": "PATCH", |
Contributor
There was a problem hiding this comment.
why we don't have this PATCH in direct?
| trap cleanup EXIT | ||
| deploy_with_plan() { | ||
| trace $CLI bundle plan > out.plan.$DATABRICKS_BUNDLE_ENGINE.txt |
Contributor
There was a problem hiding this comment.
when this function is called for the second time, it overwrites the plan file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better tests; Based on feedback at #3669 (review)