Uh oh!
There was an error while loading. Please reload this page.
gh_report: include skipped tests in the report if they match known_failures.txt - #3767
Merged
Conversation
…ilures.txt When cloud slow tests are added to known_failures.txt then TestAccept shows up as recovered even though there are no subtests that actually recovered. This PR does not fix that but at least includes those skipped tests in the output so one can understand the reason for 'RECOVERED'
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersOctober 15, 2025 11:20
ContributorAuthor
Example output for #3766 (comment) TestAccept/bundle/integration_whl/interactive_single_user is new addition
8 failing tests:
|
denik
enabled auto-merge
October 15, 2025 11:21
Collaborator
17 failing tests:
|
anton-107
approved these changes
Oct 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
denik added a commit
that referenced
this pull request
May 20, 2026
…ilures.txt (#3767) ## Why When CloudSlow tests are added to known_failures.txt then TestAccept shows up as "RECOVERED" even though there are no subtests that actually recovered. This PR does not fix that but at least includes those skipped tests in the output so one can understand the reason for "RECOVERED" status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When CloudSlow tests are added to known_failures.txt then TestAccept shows up as "RECOVERED" even though there are no subtests that actually recovered. This PR does not fix that but at least includes those skipped tests in the output so one can understand the reason for "RECOVERED" status.