Uh oh!
There was an error while loading. Please reload this page.
Pass temp dir env vars to terraform subprocesses - #395
Merged
Conversation
pietern
reviewed
May 22, 2023
Uh oh!
There was an error while loading. Please reload this page.
pietern
commented
May 22, 2023
Contributor
Thanks for debugging this! |
pietern
approved these changes
May 23, 2023
pietern
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Remaining issues w.r.t. other operating systems and testing + environment vars.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
pietern
commented
May 23, 2023
Contributor
Please also update the PR title to match current impl. |
Merged
pietern added a commit
that referenced
this pull request
May 23, 2023
## Changes CLI: * Sync: Gracefully handle broken notebook files ([#398](#398)). * Add version flag to print version and exit ([#394](#394)). * Pass temporary directory environment variables to subprocesses ([#395](#395)). * Rename environment variables `BRICKS_` -> `DATABRICKS_` ([#393](#393)). * Update to Go SDK v0.9.0 ([#396](#396)).
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes Passes through tmp dir related env vars to the terraform process. Incase any of them are not set, we assign temp dir inside bundle cache dir as the location terraform should use. ## Tests Manually checked that these env vars do override location where os.CreateTemp files are created
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes CLI: * Sync: Gracefully handle broken notebook files ([#398](#398)). * Add version flag to print version and exit ([#394](#394)). * Pass temporary directory environment variables to subprocesses ([#395](#395)). * Rename environment variables `BRICKS_` -> `DATABRICKS_` ([#393](#393)). * Update to Go SDK v0.9.0 ([#396](#396)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Passes through tmp dir related env vars to the terraform process. Incase any of them are not set, we assign temp dir inside bundle cache dir as the location terraform should use.
Tests
Manually checked that these env vars do override location where os.CreateTemp files are created