Uh oh!
There was an error while loading. Please reload this page.
Fix: Update field trigger unit test to validate on state type. - #3982
Merged
Conversation
Field triggers apply to the output of PrepareState (state type), not the input config type. This fix updates the _local test case in TestFieldTriggers to validate fieldTriggersLocal against StateType() instead of InputConfigType(). This is necessary to handle resources where the input type and output type have different JSON serializations, such as secret scopes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
shreyas-goenka
requested review from
andrewnester, anton-107, denik and pietern
as code ownersNovember 21, 2025 14:34
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2025 14:34 — with 
GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
November 21, 2025 14:38 — with GitHub Actions
Inactive
Collaborator
Commit: 95408a6
28 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 21, 2025
eng-dev-ecosystem-bot
commented
Nov 24, 2025
Collaborator
Commit: 8f1ee5b
29 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary Field triggers apply to the state type, since they are applied after `PrepareState`. They do not apply on the input config schema. This was not a problem until now because both state and config were the same. That's not the case, however, for secret scopes. Created a separate PR because of the prompt in: #3886 (comment) --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field triggers apply to the state type, since they are applied after
PrepareState. They do not apply on the input config schema. This was not a problem until now because both state and config were the same.That's not the case, however, for secret scopes. Created a separate PR because of the prompt in: #3886 (comment)