Uh oh!
There was an error while loading. Please reload this page.
Implement wsfix target to automatically fix whitespace issues - #3983
Merged
Conversation
This equalizes a diff with the current version of the templates.
pietern
requested review from
a team, andrewnester, anton-107, denik and shreyas-goenka
as code ownersNovember 21, 2025 14:37
pieterntemporarily deployed
to
test-trigger-is
November 21, 2025 14:37 — with
GitHub Actions
Inactive
- Add --fix flag support to validate_whitespace.py - Add wsfix target to Makefile for automatic whitespace fixing - Fix trailing whitespace and newline issues in 169 files
pieternforce-pushed
the
autogen-whitespace
branch
from
November 21, 2025 14:51
093e5dd to
e9e4e9fComparepieterntemporarily deployed
to
test-trigger-is
November 21, 2025 14:51 — with
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Nov 21, 2025
Collaborator
Commit: 10dd023
363 failing tests:
Top 19 slowest tests (at least 2 minutes):
|
denik
commented
Nov 21, 2025
Contributor
--fix mode is nice, but should not we fix the template instead? |
github-merge-queueBot
pushed a commit
that referenced
this pull request
Nov 21, 2025
## Changes This equalizes a diff with the current version of the templates. Note: the whitespace diffs in the apps commands came from #3948. I'm making another change to clean those up and enable the whitespace linter for all generated files in #3983. ## Why A few changes in the upstream templates caused drift.
pieterntemporarily deployed
to
test-trigger-is
November 24, 2025 08:01 — with
GitHub Actions
Inactive
pietern
commented
Nov 24, 2025
ContributorAuthor
I don't think we can enforce this upstream yet, so not having/doing |
pietern
enabled auto-merge
November 24, 2025 08:02
pieterntemporarily deployed
to
test-trigger-is
November 24, 2025 09:01 — with
GitHub Actions
Inactive
pietern
disabled auto-merge
November 24, 2025 09:48
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Nov 24, 2025
Collaborator
Commit: 51e416d
40 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This equalizes a diff with the current version of the templates. Note: the whitespace diffs in the apps commands came from #3948. I'm making another change to clean those up and enable the whitespace linter for all generated files in #3983. ## Why A few changes in the upstream templates caused drift.
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes * Add `wsfix` Makefile target and call it after codegen * Update all generated commands * Remove generated commands from `.wsignore` ## Why Whitespace issues cause unnecessary diffs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
wsfixMakefile target and call it after codegen.wsignoreWhy
Whitespace issues cause unnecessary diffs.