Uh oh!
There was an error while loading. Please reload this page.
direct: Support configuration for unordered slices; use in permissions to ignore order - #4014
Merged
Conversation
denikforce-pushed
the
denik/path-key-syntax
branch
from
November 27, 2025 10:02
61a55e6 to
9ee67c5CompareCollaborator
Commit: 575f2ba
13 failing tests:
Top 20 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
November 27, 2025 10:40
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersNovember 27, 2025 10:40
| // [Optional] KeyedSlices returns a map from path patterns to KeyFunc for comparing slices by key instead of by index. | ||
| // Example: func (*ResourcePermissions) KeyedSlices(state *PermissionsState) map[string]any | ||
| KeyedSlices(state any) map[string]any |
Contributor
There was a problem hiding this comment.
It seems like the implementation does not use the state parameter; shall it be removed?
andrewnester
approved these changes
Nov 27, 2025
denik
enabled auto-merge
November 27, 2025 15:23
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Nov 27, 2025
Collaborator
Commit: 0bc7fe3
16 failing tests:
Top 50 slowest tests (at least 2 minutes):
|
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 1, 2025
## Changes Configure "task_key" as a way to identify tasks in jobs. Builds on top of #4014 ## Why Makes diffs more precise. Ignores reordering of slice without need of sorting (#3212). Note, we still sort, this is to be reverted in separate PR. ## Tests Existing tests. New test that reorders tasks locally.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 1, 2025
## Why Otherwise it is also applied to key-value pairs which is not intended. This is related and fixes bug introduced in #4014 ## Tests Regression acceptance test that shows how old behaviour resulted in ignoring extra permissions in remote state on direct.
denik added a commit
that referenced
this pull request
May 20, 2026
…s to ignore order (#4014) ## Changes - Extend structpath to support [key=‘value’] syntax. - Extend structdiff with extra parameter that maps path to keyFunc which is a function that returns key/value pair for a given slice element. They pair is used to identify the slice element. - Use this functionality on permissions resource in direct to solve drift due to backend reordering permissions. ## Why - Prevent remote drift due to backend reordering slice elements. - Make diffs more readable / precise. This is an alternative to always sorting the input, which destroys the references ($resources.jobs.foo.tasks[1] is not valid today because of sorting). In a follow up PR I’ll revert job tasks sorting #3212 and implement KeyedSlices instead.
denik added a commit
that referenced
this pull request
May 20, 2026
## Changes Configure "task_key" as a way to identify tasks in jobs. Builds on top of #4014 ## Why Makes diffs more precise. Ignores reordering of slice without need of sorting (#3212). Note, we still sort, this is to be reverted in separate PR. ## Tests Existing tests. New test that reorders tasks locally.
denik added a commit
that referenced
this pull request
May 20, 2026
## Why Otherwise it is also applied to key-value pairs which is not intended. This is related and fixes bug introduced in #4014 ## Tests Regression acceptance test that shows how old behaviour resulted in ignoring extra permissions in remote state on direct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
This is an alternative to always sorting the input, which destroys the references ($resources.jobs.foo.tasks[1] is not valid today because of sorting). In a follow up PR I’ll revert job tasks sorting #3212 and implement KeyedSlices instead.