Skip to content

Fix lakeview publish to explicitly send embed_credentials as false by default - #4066

Merged
denik merged 8 commits into
databricks:mainfrom
varundeepsaini:fix-lakeview-embed-credentials-default
Dec 18, 2025
Merged

Fix lakeview publish to explicitly send embed_credentials as false by default#4066
denik merged 8 commits into
databricks:mainfrom
varundeepsaini:fix-lakeview-embed-credentials-default

Conversation

@varundeepsaini

@varundeepsainivarundeepsaini commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

Fixes: #4001

Changes

Add override for lakeview publish to explicitly send embed_credentials: false when --embed-credentials flag is not provided.

Why

The SDK omits false boolean values from JSON requests due to omitempty. This caused the API to default to true, embedding credentials even when the flag wasn't set. The fix uses ForceSendFields to always send the value explicitly.

Tests

Added acceptance test verifying the request body contains "embed_credentials": false.

@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

hey @andrewnester
can you please review this pr

@andrewnesterandrewnester left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding tests but overall looks good! @denik could you TAL as well?

Comment threadacceptance/workspace/lakeview/publish/test.toml Outdated
@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

@andrewnester pushed the changes,
After you have a look, please queue the tests as well
thankss

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Commit: 22007ee

Run: 20303352556

Env🟨​KNOWN🔄​flaky💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
🟨​aws linux137136764721:02
🟨​aws windows1327136764518:57
🟨​aws-ucws linux911151053224:45
🟨​aws-ucws windows911151253024:19
🟨​azure linux86336864519:55
🟨​azure windows131337064319:08
🟨​azure-ucws linux68350753021:51
🟨​azure-ucws windows68350952824:48
🟨​gcp linux86335765119:03
🟨​gcp windows131335964919:07
23 interesting tests: 20 KNOWN, 2 flaky, 1 SKIP
Test Nameaws linuxaws windowsaws-ucws linuxaws-ucws windowsazure linuxazure windowsazure-ucws linuxazure-ucws windowsgcp linuxgcp windows
🟨​TestAccept🟨​K🟨​K🟨​K🟨​K💚​R💚​R💚​R💚​R💚​R💚​R
🙈​TestAccept/bundle/resources/permissions🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions🟨​K🟨​K🟨​K🟨​K🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct🟨​K🟨​K🟨​K🟨​K
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform🟨​K🟨​K💚​R💚​R
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions🟨​K🟨​K💚​R💚​R🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct🟨​K🟨​K💚​R💚​R
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform🟨​K🟨​K💚​R💚​R
🔄​TestAccept/bundle/resources/secret_scopes/permissions✅​p🔄​f✅​p✅​p✅​p✅​p✅​p✅​p🙈​s🙈​s
🔄​TestAccept/bundle/resources/secret_scopes/permissions/DATABRICKS_BUNDLE_ENGINE=terraform✅​p🔄​f✅​p✅​p✅​p✅​p✅​p✅​p
🟨​TestFsRmNonEmptyDirectory🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFsRmNonEmptyDirectory/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestExport💚​R💚​R💚​R💚​R🟨​K🟨​K💚​R💚​R🟨​K🟨​K
🟨​TestExportWithFileFlag💚​R💚​R💚​R💚​R🟨​K🟨​K💚​R💚​R🟨​K🟨​K
🟨​TestImportDir💚​R💚​R💚​R💚​R💚​R🟨​K💚​R💚​R💚​R🟨​K
🟨​TestImportDirDoesNotOverwrite💚​R💚​R💚​R💚​R💚​R🟨​K💚​R💚​R💚​R🟨​K
🟨​TestImportDirWithOverwriteFlag💚​R💚​R💚​R💚​R💚​R🟨​K💚​R💚​R💚​R🟨​K
🟨​TestImportFileFormatAuto💚​R💚​R💚​R💚​R💚​R🟨​K💚​R💚​R💚​R🟨​K
🟨​TestImportFileFormatSource💚​R💚​R💚​R💚​R💚​R🟨​K💚​R💚​R💚​R🟨​K
🟨​TestFilerReadWrite🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerReadWrite/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerRecursiveDelete🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerRecursiveDelete/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
Top 24 slowest tests (at least 2 minutes):
durationenvtestname
6:29aws-ucws linuxTestAccept/bundle/resources/synced_database_tables/basic
6:17aws-ucws windowsTestAccept/bundle/resources/synced_database_tables/basic
6:05aws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:53aws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:52gcp linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:46aws-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:46aws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:40aws-ucws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
5:40aws-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:26gcp linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:25gcp windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:14aws-ucws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
5:10gcp windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:33azure-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
4:07azure-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
4:02azure windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:38azure windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
3:27azure linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
3:11azure-ucws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
3:05azure-ucws linuxTestAccept/bundle/resources/synced_database_tables/basic
3:04azure-ucws windowsTestAccept/bundle/resources/synced_database_tables/basic
2:42aws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
2:42azure-ucws linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
2:32azure linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct

auto-merge was automatically disabled December 5, 2025 15:25

Head branch was pushed to by a user without write access

@varundeepsaini
varundeepsainiforce-pushed the fix-lakeview-embed-credentials-default branch from 77a78a7 to ec40595CompareDecember 5, 2025 16:16
@varundeepsaini
varundeepsainiforce-pushed the fix-lakeview-embed-credentials-default branch from ec40595 to 5dbf42aCompareDecember 6, 2025 06:52
@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

@andrewnester there was a test failing on windows, fixed it,
After you have a look, please queue the tests as well
thankss

@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

@andrewnester can we merge this ?

@denik

Copy link
Copy Markdown
Contributor

@varundeepsaini we can merge this, could you add NEXT_CHANGELOG entry?

@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

@denik added

@denik

Copy link
Copy Markdown
Contributor

@varundeepsaini did you push? I don't see it.

@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

my bad, pushed now

@denik
denik enabled auto-merge December 16, 2025 15:27
@varundeepsaini

Copy link
Copy Markdown
ContributorAuthor

@denik, is there any way I can determine which integration tests are failing?
Would be great if you could share the logs, ill take a look

auto-merge was automatically disabled December 16, 2025 17:55

Head branch was pushed to by a user without write access

@varundeepsaini
varundeepsainiforce-pushed the fix-lakeview-embed-credentials-default branch from e00f349 to c84c26bCompareDecember 16, 2025 17:55
@github-actions

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 4066
  • Commit SHA: 22007ee3add89e62afd0421754115567fbc119d4

Checks will be approved automatically on success.

@denik
denik enabled auto-merge December 17, 2025 12:49
@denikdenik changed the title Fix lakeview publish to default embed_credentials to falseFix lakeview publish to explicitly send embed_credentials as false by defaultDec 17, 2025
@denik
denik disabled auto-merge December 18, 2025 09:30
@denik
denik merged commit e2f98af into databricks:mainDec 18, 2025
18 of 19 checks passed
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Commit: e2f98af

Run: 20332330148

Env❌​FAIL🟨​KNOWN🔄​flaky💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
🟨​aws linux155140663359:19
❌​aws windows220140663162:35
🟨​aws-ucws linux119156751282:11
❌​aws-ucws windows2182156751092:29
🟨​azure linux855340363168:26
🟨​azure windows131340962963:09
❌​azure-ucws linux16953548510118:03
❌​azure-ucws windows14143552508111:21
🟨​gcp linux835338564062:51
❌​gcp windows514338463861:03
47 interesting tests: 22 FAIL, 20 KNOWN, 4 flaky, 1 SKIP
Test Nameaws linuxaws windowsaws-ucws linuxaws-ucws windowsazure linuxazure windowsazure-ucws linuxazure-ucws windowsgcp linuxgcp windows
🟨​TestAccept🟨​K🟨​K🟨​K🟨​K🔄​f💚​R🟨​K🟨​K🔄​f🟨​K
❌​TestAccept/bundle/integration_whl/interactive_cluster✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p❌​F
❌​TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p✅​p✅​p✅​p❌​F✅​p✅​p
❌​TestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p❌​F
❌​TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F🔄​f❌​F
❌​TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=SINGLE_USER✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F🔄​f✅​p
❌​TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=USER_ISOLATION✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p❌​F
❌​TestAccept/bundle/integration_whl/interactive_single_user✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/resources/clusters/deploy/update-after-create✅​p✅​p✅​p✅​p✅​p✅​p❌​F✅​p✅​p✅​p
❌​TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p✅​p✅​p❌​F✅​p✅​p✅​p
❌​TestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p✅​p✅​p✅​p❌​F✅​p✅​p✅​p
❌​TestAccept/bundle/resources/clusters/run/spark_python_task✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
❌​TestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p✅​p✅​p✅​p❌​F❌​F✅​p✅​p
🔄​TestAccept/bundle/resources/dashboards/detect-change✅​p✅​p✅​p✅​p🔄​f✅​p✅​p✅​p✅​p✅​p
🔄​TestAccept/bundle/resources/dashboards/detect-change/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p🔄​f✅​p✅​p✅​p✅​p✅​p
❌​TestAccept/bundle/resources/dashboards/simple✅​p✅​p✅​p❌​F✅​p✅​p✅​p✅​p✅​p✅​p
❌​TestAccept/bundle/resources/dashboards/simple/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p❌​F✅​p✅​p✅​p✅​p✅​p✅​p
🙈​TestAccept/bundle/resources/permissions🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions🟨​K🟨​K🟨​K🟨​K🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=direct🟨​K🟨​K🟨​K🟨​K
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions/DATABRICKS_BUNDLE_ENGINE=terraform🟨​K🟨​K💚​R💚​R
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions🟨​K🟨​K💚​R🟨​K🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=direct🟨​K🟨​K💚​R💚​R
🟨​TestAccept/bundle/resources/permissions/jobs/destroy_without_mgmtperms/without_permissions/DATABRICKS_BUNDLE_ENGINE=terraform🟨​K🟨​K💚​R🟨​K
❌​TestAccept/bundle/resources/secret_scopes/permissions✅​p❌​F✅​p✅​p✅​p✅​p✅​p✅​p🙈​s🙈​s
❌​TestAccept/bundle/resources/secret_scopes/permissions/DATABRICKS_BUNDLE_ENGINE=terraform✅​p❌​F✅​p✅​p✅​p✅​p✅​p✅​p
❌​TestAccept/ssh/connection✅​p✅​p✅​p✅​p✅​p✅​p✅​p✅​p✅​p❌​F
🔄​TestSparkJarTaskDeployAndRunOnWorkspace✅​p✅​p✅​p✅​p🔄​f✅​p✅​p✅​p✅​p✅​p
🔄​TestSparkJarTaskDeployAndRunOnWorkspace/Databricks_Runtime_15.4_LTS✅​p✅​p✅​p✅​p🔄​f✅​p✅​p✅​p✅​p✅​p
🟨​TestFsRmNonEmptyDirectory🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFsRmNonEmptyDirectory/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestExport🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestExportWithFileFlag🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestImportDir💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K
🟨​TestImportDirDoesNotOverwrite💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K
🟨​TestImportDirWithOverwriteFlag💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K
🟨​TestImportFileFormatAuto💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K
🟨​TestImportFileFormatSource💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K💚​R🟨​K
🟨​TestFilerReadWrite🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerReadWrite/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerRecursiveDelete🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
🟨​TestFilerRecursiveDelete/dbfs🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K🟨​K
Top 50 slowest tests (at least 2 minutes):
durationenvtestname
32:18azure-ucws linuxTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
30:27azure-ucws linuxTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
25:49azure-ucws windowsTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
24:42azure-ucws windowsTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
20:09gcp windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
17:06azure linuxTestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform
15:48gcp windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
15:27azure-ucws linuxTestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct
14:50aws-ucws linuxTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
14:34aws windowsTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
14:21aws-ucws windowsTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
14:04gcp linuxTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
13:45azure-ucws windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
13:42azure-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
13:26gcp linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
12:39gcp windowsTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=SINGLE_USER
12:37aws-ucws linuxTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=direct
11:31aws-ucws windowsTestAccept/bundle/resources/model_serving_endpoints/running-endpoint/DATABRICKS_BUNDLE_ENGINE=terraform
10:48aws linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
10:47gcp windowsTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
10:43gcp windowsTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
10:34azure windowsTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform
10:12azure-ucws linuxTestAccept/bundle/resources/permissions/factcheck/DATABRICKS_BUNDLE_ENGINE=terraform
9:59gcp linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=USER_ISOLATION
9:52aws-ucws linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
9:48aws windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
9:48aws-ucws windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
9:44gcp windowsTestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
9:44azure-ucws windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
9:30gcp windowsTestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=direct
9:24aws linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
9:17gcp linuxTestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=direct
9:11azure-ucws windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
9:00azure-ucws linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:55aws linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:52azure windowsTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:46azure linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:43gcp linuxTestAccept/bundle/run/app-with-job/DATABRICKS_BUNDLE_ENGINE=terraform
8:36azure windowsTestSparkJarTaskDeployAndRunOnWorkspace/Databricks_Runtime_15.4_LTS
8:27gcp linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=USER_ISOLATION
8:08aws-ucws windowsTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
8:05gcp linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=terraform
8:04aws-ucws linuxTestAccept/bundle/integration_whl/interactive_cluster/DATABRICKS_BUNDLE_ENGINE=direct
8:01aws windowsTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=direct
8:00gcp linuxTestAccept/bundle/resources/clusters/run/spark_python_task/DATABRICKS_BUNDLE_ENGINE=direct
7:59gcp linuxTestAccept/bundle/integration_whl/base/DATABRICKS_BUNDLE_ENGINE=direct
7:57aws-ucws linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=terraform/DATA_SECURITY_MODE=SINGLE_USER
7:57aws linuxTestAccept/bundle/integration_whl/interactive_cluster_dynamic_version/DATABRICKS_BUNDLE_ENGINE=direct/DATA_SECURITY_MODE=SINGLE_USER
7:56aws-ucws windowsTestSparkJarTaskDeployAndRunOnVolumes/Databricks_Runtime_13.3_LTS
7:56aws-ucws linuxTestAccept/bundle/integration_whl/interactive_single_user/DATABRICKS_BUNDLE_ENGINE=terraform

deco-sdk-taggingBot added a commit that referenced this pull request Dec 18, 2025
## Release v0.281.0
### CLI
* Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066))
### Bundles
* Add support for configurable catalog/schema for dashboards ([#4130](#4130))
* Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135))
* `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments.
* engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134))
* engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105))
### Dependency updates
* Upgrade Go SDK to 0.94.0 ([#4148](#4148))
* Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
@varundeepsaini
varundeepsaini deleted the fix-lakeview-embed-credentials-default branch December 19, 2025 17:01
denik added a commit that referenced this pull request May 20, 2026
… default (#4066)
Fixes: #4001
## Changes
Add override for `lakeview publish` to explicitly send
`embed_credentials: false` when `--embed-credentials` flag is not
provided.
## Why
The SDK omits `false` boolean values from JSON requests due to
`omitempty`. This caused the API to default to `true`, embedding
credentials even when the flag wasn't set. The fix uses
`ForceSendFields` to always send the value explicitly.
## Tests
Added acceptance test verifying the request body contains
`"embed_credentials": false`.
---------
Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
denik pushed a commit that referenced this pull request May 20, 2026
## Release v0.281.0
### CLI
* Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066))
### Bundles
* Add support for configurable catalog/schema for dashboards ([#4130](#4130))
* Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135))
* `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments.
* engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134))
* engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105))
### Dependency updates
* Upgrade Go SDK to 0.94.0 ([#4148](#4148))
* Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] For command 'lakeview publish', parameter '--embed-credentials' always set

4 participants

@varundeepsaini@eng-dev-ecosystem-bot@denik@andrewnester