Uh oh!
There was an error while loading. Please reload this page.
Fix lakeview publish to explicitly send embed_credentials as false by default - #4066
Conversation
varundeepsaini
commented
Dec 2, 2025
hey @andrewnester |
andrewnester
left a comment
There was a problem hiding this comment.
Minor comment regarding tests but overall looks good! @denik could you TAL as well?
Uh oh!
There was an error while loading. Please reload this page.
varundeepsaini
commented
Dec 4, 2025
@andrewnester pushed the changes, |
Commit: 22007ee
23 interesting tests: 20 KNOWN, 2 flaky, 1 SKIP
Top 24 slowest tests (at least 2 minutes):
|
Head branch was pushed to by a user without write access
77a78a7 to
ec40595Compareec40595 to
5dbf42aComparevarundeepsaini
commented
Dec 6, 2025
@andrewnester there was a test failing on windows, fixed it, |
varundeepsaini
commented
Dec 16, 2025
@andrewnester can we merge this ? |
denik
commented
Dec 16, 2025
@varundeepsaini we can merge this, could you add NEXT_CHANGELOG entry? |
varundeepsaini
commented
Dec 16, 2025
@denik added |
denik
commented
Dec 16, 2025
@varundeepsaini did you push? I don't see it. |
varundeepsaini
commented
Dec 16, 2025
my bad, pushed now |
varundeepsaini
commented
Dec 16, 2025
@denik, is there any way I can determine which integration tests are failing? |
Head branch was pushed to by a user without write access
e00f349 to
c84c26bCompareAn authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Dec 18, 2025
Commit: e2f98af
47 interesting tests: 22 FAIL, 20 KNOWN, 4 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
## Release v0.281.0 ### CLI * Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066)) ### Bundles * Add support for configurable catalog/schema for dashboards ([#4130](#4130)) * Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135)) * `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments. * engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134)) * engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105)) ### Dependency updates * Upgrade Go SDK to 0.94.0 ([#4148](#4148)) * Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
… default (#4066) Fixes: #4001 ## Changes Add override for `lakeview publish` to explicitly send `embed_credentials: false` when `--embed-credentials` flag is not provided. ## Why The SDK omits `false` boolean values from JSON requests due to `omitempty`. This caused the API to default to `true`, embedding credentials even when the flag wasn't set. The fix uses `ForceSendFields` to always send the value explicitly. ## Tests Added acceptance test verifying the request body contains `"embed_credentials": false`. --------- Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
## Release v0.281.0 ### CLI * Fix lakeview publish to default `embed_credentials` to false ([#4066](#4066)) ### Bundles * Add support for configurable catalog/schema for dashboards ([#4130](#4130)) * Pass SYSTEM\_ACCESSTOKEN from env to the Terraform provider ([#4135](#4135)) * `bundle deployment migrate`: when running `bundle plan` propagate `-var` arguments. * engine/direct: New option --plan to `bundle deploy` to deploy previously saved plan (saved plan with `bundle plan -o json`) ([#4134](#4134)) * engine/direct: Fix dependency-ordered deletion by persisting depends\_on in state ([#4105](#4105)) ### Dependency updates * Upgrade Go SDK to 0.94.0 ([#4148](#4148)) * Upgrade Terraform provider to 1.100.0 ([#4150](#4150))
Fixes: #4001
Changes
Add override for
lakeview publishto explicitly sendembed_credentials: falsewhen--embed-credentialsflag is not provided.Why
The SDK omits
falseboolean values from JSON requests due toomitempty. This caused the API to default totrue, embedding credentials even when the flag wasn't set. The fix usesForceSendFieldsto always send the value explicitly.Tests
Added acceptance test verifying the request body contains
"embed_credentials": false.