Uh oh!
There was an error while loading. Please reload this page.
Improve folder permissions warning - #4216
Merged
Merged
Conversation
Update the warning message shown when workspace folder has permissions not configured in the bundle. The new message provides clear guidance on how to resolve the issue. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This fixes several issues with the folder permissions validation: 1. Permission hierarchy: Bundle CAN_MANAGE now properly supersedes workspace CAN_VIEW for the same principal (no false warning) 2. Deduplication: When the API returns both inherited and explicit permissions for the same principal, keep only the highest level 3. Current user groups: Suppress warnings for groups the current user belongs to when the user is already tracked in the bundle Also moves PermissionOrder and helpers to resources package for reuse. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove untested current user group tracking code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lennartkats-db
requested review from
andrewnester, anton-107, denik, pietern and shreyas-goenka
as code ownersJanuary 8, 2026 08:49
lennartkats-dbtemporarily deployed
to
test-trigger-is
January 8, 2026 08:49 — with
GitHub Actions
Inactive
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
lennartkats-dbtemporarily deployed
to
test-trigger-is
January 8, 2026 08:52 — with
GitHub Actions
Inactive
Collaborator
Commit: f80e15d
27 interesting tests: 17 KNOWN, 8 RECOVERED, 1 SKIP, 1 flaky
Top 20 slowest tests (at least 2 minutes):
|
lennartkats-dbtemporarily deployed
to
test-trigger-is
January 8, 2026 17:24 — with
GitHub Actions
Inactive
andrewnester
approved these changes
Jan 9, 2026
lennartkats-db
enabled auto-merge
January 10, 2026 09:18
lennartkats-dbtemporarily deployed
to
test-trigger-is
January 10, 2026 09:18 — with
GitHub Actions
Inactive
# Conflicts: # NEXT_CHANGELOG.md
lennartkats-dbforce-pushed
the
improve-warning
branch
from
January 11, 2026 16:31
b564b9e to
77c9d82Comparelennartkats-dbtemporarily deployed
to
test-trigger-is
January 11, 2026 16:32 — with
GitHub Actions
Inactive
lennartkats-dbtemporarily deployed
to
test-trigger-is
January 11, 2026 16:35 — with
GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jan 11, 2026
Collaborator
Commit: f4f794c
29 interesting tests: 17 KNOWN, 8 RECOVERED, 3 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jan 14, 2026
## Release v0.283.0 ### Notable Changes * Bundle commands now cache the user's account details to improve command latency. To disable this, set the environment variable DATABRICKS_CACHE_ENABLED to false. ### CLI * Add commands to pipelines command group ([#4275](#4275)) ### Bundles * Add support for configuring app.yaml options for apps via bundle config ([#4271](#4271)) * Enable caching user identity by default ([#4202](#4202)) * Do not show single node warning when is_single_node option is explicitly set ([#4272](#4272)) * Fix false positive folder permission warnings and make them more actionable ([#4216](#4216)) * Pass additional Azure DevOps system variables ([#4236](#4236)) * Replace Black formatter with Ruff in Python bundle templates for faster, all-in-one linting and formatting ([#4196](#4196)) * engine/direct: support quality monitors ([#4278](#4278)) * Improve folder permissions warning ([#4216](#4216)) ### Dependency updates * Upgrade TF provider to 1.102.0 ([#4235](#4235)) * Upgrade Go SDK to 0.96.0 ([#4206](#4206))
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes This improves the folder permissions warnings, fixing false positives and making any warnings more actionable. - Make the warning message more actionable with clearer details - Fix false positive warnings when bundle grants higher permission than workspace - Fix duplicate permission entries from inherited + explicit permissions - Simplify code by removing untested current user group tracking ## Testing - [x] Unit tests pass - [x] Manually tested with bundle deploy --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Release v0.283.0 ### Notable Changes * Bundle commands now cache the user's account details to improve command latency. To disable this, set the environment variable DATABRICKS_CACHE_ENABLED to false. ### CLI * Add commands to pipelines command group ([#4275](#4275)) ### Bundles * Add support for configuring app.yaml options for apps via bundle config ([#4271](#4271)) * Enable caching user identity by default ([#4202](#4202)) * Do not show single node warning when is_single_node option is explicitly set ([#4272](#4272)) * Fix false positive folder permission warnings and make them more actionable ([#4216](#4216)) * Pass additional Azure DevOps system variables ([#4236](#4236)) * Replace Black formatter with Ruff in Python bundle templates for faster, all-in-one linting and formatting ([#4196](#4196)) * engine/direct: support quality monitors ([#4278](#4278)) * Improve folder permissions warning ([#4216](#4216)) ### Dependency updates * Upgrade TF provider to 1.102.0 ([#4235](#4235)) * Upgrade Go SDK to 0.96.0 ([#4206](#4206))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This improves the folder permissions warnings, fixing false positives and making any warnings more actionable.
Testing