Uh oh!
There was an error while loading. Please reload this page.
acc: make read_id.py update replacements; add replace_all.py & add_repl.py - #4238
Merged
Conversation
denik
requested review from
andrewnester, anton-107, pietern and shreyas-goenka
as code ownersJanuary 9, 2026 13:13
Collaborator
Commit: f6a8331
30 interesting tests: 17 KNOWN, 8 RECOVERED, 4 flaky, 1 SKIP
Top 22 slowest tests (at least 2 minutes):
|
pietern
approved these changes
Jan 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 9, 2026
Use #4238 to get more specific output.
eng-dev-ecosystem-bot
commented
Jan 9, 2026
Collaborator
Commit: ca66e13
35 interesting tests: 13 KNOWN, 12 RECOVERED, 4 FAIL, 3 BUG, 2 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
pietern added a commit
that referenced
this pull request
Jan 12, 2026
Update expected output to use [FOO_ID] instead of [JOB_ID] to match the new behavior introduced in PR #4238 (ca66e13). PR #4238 changed the test script to use replace_ids.py, which generates resource-specific replacement tokens (e.g., [FOO_ID] for job "foo") instead of generic [JOB_ID]. Fixes test failures across all 10 environments since Jan 9, 2026. Related: #4238
denik added a commit
that referenced
this pull request
May 20, 2026
…pl.py (#4238) ## Changes - The read_id.py script will now automatically update ACC_REPLS with a given id. - New script replace_ids.py adds replacements for all available resource ids from the state. - New script add_repl.py is an alternative to `echo >> ACC_REPLS` but will automatically add _2, _3... suffixes if replacement already exist. ## Why Simplify script writing. I'd also like to remove generic NUMID and UUID replacements and rely replace_ids.py instead. Seeing IDs is sometimes necessary. ## Tests Existing tests, new selftest.
denik added a commit
that referenced
this pull request
May 20, 2026
Use #4238 to get more specific output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
echo >> ACC_REPLSbut will automatically add _2, _3... suffixes if replacement already exist.Why
Simplify script writing.
I'd also like to remove generic NUMID and UUID replacements and rely replace_ids.py instead. Seeing IDs is sometimes necessary.
Tests
Existing tests, new selftest.