Uh oh!
There was an error while loading. Please reload this page.
Add Claude Code workflow for AI-assisted PR reviews - #4738
Draft
shreyas-goenka wants to merge 6 commits into
Draft
Add Claude Code workflow for AI-assisted PR reviews#4738shreyas-goenka wants to merge 6 commits into
shreyas-goenka wants to merge 6 commits into
Conversation
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 16:30 — with 
GitHub Actions
Inactive
Collaborator
Commit: 3cf6d9b
18 interesting tests: 7 SKIP, 6 RECOVERED, 5 flaky
Top 20 slowest tests (at least 2 minutes):
|
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 16:42 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 17:19 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 17:58 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 13, 2026 19:56
b418b20 to
0d2b698Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 19:56 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 13, 2026 20:03
0d2b698 to
6dbf8a3Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 20:04 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 13, 2026 20:17
6dbf8a3 to
275b67aCompareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 20:18 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 13, 2026 20:25
275b67a to
fc25d50Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 20:26 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 13, 2026 20:33
fc25d50 to
47a7034Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 20:33 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:14 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:28 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:33 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:38 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:40 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:47 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:49 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:51 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 22:58 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:01 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:04 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:06 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:08 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:10 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 13, 2026 23:34 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 14, 2026 14:44 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 14, 2026 14:50
8e9e3f0 to
2ade542Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 14, 2026 14:51 — with GitHub Actions
Inactive
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 14, 2026 14:55
2ade542 to
c46e877Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 14, 2026 14:55 — with GitHub Actions
Inactive
Add a GitHub Actions workflow that provides AI-assisted PR reviews and interactive @claude mentions using Claude Code backed by Databricks Model Serving. The workflow dispatches to eng-dev-ecosystem's protected runners (whose IPs are allowlisted by the Databricks account IP ACL) via the DECO workflow trigger GitHub App. Two modes: - Review: automatic on PR open, posts a review comment - Assist: triggered by @claude mentions, can edit code and push Access is restricted to COLLABORATOR/MEMBER/OWNER via author_association allowlists. Co-authored-by: Isaac
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 14, 2026 15:22
c46e877 to
1713c27Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 14, 2026 15:23 — with GitHub Actions
Inactive
eng-dev-ecosystem-bot
left a comment
Collaborator
There was a problem hiding this comment.
Workflow looks well-structured overall. Good security practices: fork PR checks, author_association allowlists, and using process.env to avoid script injection for comment_body. Two minor observations below.
| workflow_id: 'cli-claude-code.yml', | ||
| ref: 'main', | ||
| inputs: { | ||
| pull_request_number: '${{ steps.pr.outputs.number }}', |
Collaborator
There was a problem hiding this comment.
Nit: steps.pr.outputs.number is interpolated directly into the script block via ${{ }}. This is safe in practice (it's a GitHub-assigned integer), but it's inconsistent with line 131 where comment_body correctly uses process.env to avoid expression injection.
For defense-in-depth, consider passing this through an env var too:
env:
COMMENT_BODY: ${{ github.event.comment.body }}PR_NUMBER: ${{ steps.pr.outputs.number }}pull_request_number: process.env.PR_NUMBER,| (github.event_name == 'issue_comment' && github.event.issue.pull_request && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) | ||
| ) | ||
| runs-on: |
Collaborator
There was a problem hiding this comment.
Minor: The assist job has no concurrency group, unlike review (line 34-36). Multiple @claude mentions on the same PR could trigger parallel dispatches. If that's intentional, a brief comment would help; otherwise, consider adding:
concurrency:
group: claude-assist-${{ github.event.issue.number || github.event.pull_request.number }}cancel-in-progress: trueshreyas-goenka
commented
Mar 15, 2026
ContributorAuthor
@claude reply to me in this PR with a comment saying hi |
shreyas-goenka
commented
Mar 15, 2026
ContributorAuthor
@claude say hi |
Collaborator
Integration test reportCommit: f2eb6a2
26 interesting tests: 13 SKIP, 7 RECOVERED, 4 flaky, 2 FAIL
Top 20 slowest tests (at least 2 minutes):
|
eng-dev-ecosystem-bot
left a comment
Collaborator
There was a problem hiding this comment.
Clean, well-structured workflow. Good security practices: fork checks on both jobs, author association gating, and passing comment_body through process.env instead of ${{ }} interpolation to avoid script injection. One suggestion below.
| ( | ||
| (github.event_name == 'issue_comment' && github.event.issue.pull_request && contains(github.event.comment.body, '@claude')) || | ||
| (github.event_name == 'pull_request_review_comment' && contains(github.event.comment.body, '@claude')) | ||
| ) |
Collaborator
There was a problem hiding this comment.
Nit: The review job has a concurrency group to cancel in-progress runs, but assist does not. If someone posts multiple @claude comments in quick succession, they could all trigger simultaneously. Consider adding:
concurrency:
group: claude-assist-${{ github.event.issue.number || github.event.pull_request.number }}cancel-in-progress: trueshreyas-goenka
commented
Mar 16, 2026
ContributorAuthor
@claude is elon musk the founder of computing? |
After dispatching to eng-dev-ecosystem, the workflow now finds the remote run, posts a link in the step summary, and waits for it to complete. This keeps the check visible on the PR while Claude works. Co-authored-by: Isaac
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 16, 2026 12:47 — with GitHub Actions
Inactive
- Pin actions to commit SHAs instead of mutable version tags - Add concurrency group to assist job to prevent parallel dispatches - Pass PR number through env var for defense-in-depth against injection Co-authored-by: Isaac
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 16, 2026 12:50 — with GitHub Actions
Inactive
Reflects current implementation: composite action, standalone workflows, OIDC policies, SHA-pinned actions, concurrency groups, allowed tools, and comprehensive threat model. Co-authored-by: Isaac
shreyas-goenkatemporarily deployed
to
test-trigger-is
March 16, 2026 12:52 — with GitHub Actions
Inactive
Co-authored-by: Isaac
shreyas-goenkaforce-pushed
the
add-claude-code-workflow
branch
from
March 16, 2026 12:56
f2d638a to
b640037Compareshreyas-goenkatemporarily deployed
to
test-trigger-is
March 16, 2026 12:56 — with GitHub Actions
Inactive
Contributor
This PR has not received an update in a while. If you want to keep this PR open, please leave a comment below or push a new commit and auto-close will be canceled. |
Drop the interactive @claude assist job and the issue_comment / pull_request_review_comment triggers; keep only the automatic review on PR open. Also stop passing event_type to cli-claude-code.yml, which is now review-only. Co-authored-by: Isaac
shreyas-goenkatemporarily deployed
to
test-trigger-is
June 19, 2026 14:02 — with GitHub Actions
Inactive
shreyas-goenkatemporarily deployed
to
test-trigger-is
June 19, 2026 14:02 — with GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions workflow for AI-assisted PR reviews and interactive
@claudementions. This is a thin dispatcher — it triggers execution indatabricks-eng/eng-dev-ecosystemon protected runners via the DECO workflow trigger GitHub App.@claudecomments, can edit and pushAccess restricted to org
MEMBER/OWNERviaauthor_associationallowlists.Depends on
https://github.com/databricks-eng/eng-dev-ecosystem/pull/1202
Test plan
@claudeassist mode tested