Uh oh!
There was an error while loading. Please reload this page.
Switch auth logout from --force to --auto-approve - #4755
Merged
Conversation
mihaimitrea-dbtemporarily deployed
to
test-trigger-is
March 16, 2026 10:51 — with 
GitHub Actions
Inactive
Collaborator
Commit: aef434e
18 interesting tests: 9 SKIP, 6 RECOVERED, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
mihaimitrea-dbtemporarily deployed
to
test-trigger-is
March 16, 2026 12:29 — with GitHub Actions
Inactive
--auto-approve flag to auth logout and fix stale account_id token cleanup--auto-approve flag to auth logout and fix stale account_id token cleanupauth logout from --force to --auto-approvemihaimitrea-dbforce-pushed
the
mihaimitrea-db/auth-logout-flag-fix
branch
from
April 10, 2026 11:40
6bc1680 to
6a93a4bComparemihaimitrea-db
marked this pull request as ready for review
April 10, 2026 11:41
mihaimitrea-db
requested review from
andrewnester, anton-107, denik, pietern, shreyas-goenka and simonfaltum
as code ownersApril 10, 2026 11:41
simonfaltum
approved these changes
Apr 10, 2026
Replace the logout-specific --force flag with --auto-approve, matching the pattern used by bundle deploy, bundle destroy, and other commands.
mihaimitrea-dbforce-pushed
the
mihaimitrea-db/auth-logout-flag-fix
branch
from
April 10, 2026 11:56
6a93a4b to
54b8f14Comparemihaimitrea-db
enabled auto-merge
April 10, 2026 12:21
Uh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Apr 10, 2026
## Changes - Add a traceability comment block at the top of `cmd/auth/logout.go` linking to the three original PRs (#4613, #4616, #4647). These PRs were inadvertently squashed into a single commit `cb3c326` titled after #4647 only. - The comment reflects the `--force` → `--auto-approve` rename from #4755. - Add a `NEXT_CHANGELOG.md` entry for `auth logout` under the CLI section. - Remove `Hidden: true` from the logout command so it appears in `databricks auth -h` and tab completion. - Improve the command's long description to: - Document that token cleanup only applies to profiles created by `databricks auth login` - Note that logging out of one profile does not affect others sharing the same cached token - Condense the numbered items (drop the redundant `--auto-approve` item since it's already mentioned in items 1 and 2; fold `--delete` into a single item) ## Why The `auth logout` feature was implemented across three stacked PRs (#4613, #4616, #4647) that were squashed into one commit on merge. The commit title only references the last PR ("Extract shared SelectProfile helper"), so `auth logout` itself has no changelog entry and no git-blame traceability. This followup restores that context, unhides the command for users, and adds the missing changelog entry. ## Tests No functional changes; existing unit and acceptance tests for `auth logout` continue to pass. --------- Co-authored-by: simon <simon.faltum@databricks.com>
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes * Replace the logout-specific `--force` flag with `--auto-approve`, matching the pattern used by `bundle deploy`, `bundle destroy`, and other commands. * Register `--auto-approve` directly on the `auth logout` command instead of relying on an unregistered global `--yes` flag. * Stop registering a local `--profile` flag on `auth logout` — read the value from the shared flag already available on the command tree. * Update the logout help text, non-interactive error message, and unit/acceptance tests to reflect the `--auto-approve` behavior. ## Why The `--force` flag was specific to `auth logout`. Switching to `--auto-approve` aligns with the rest of the CLI's confirmation-skip pattern (`bundle deploy --auto-approve`, `bundle destroy --auto-approve`, etc.). `auth logout` was defining its own `--profile` flag, overriding the global one. Removing it and defaulting to the root behavior keeps UX aligned with other commands and removes a duplicate flag definition that can drift over time. ## Tests * `go test ./cmd/auth -run TestLogout -count=1` * `go test ./acceptance -run TestAccept/cmd/auth/logout -test.v`
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Changes - Add a traceability comment block at the top of `cmd/auth/logout.go` linking to the three original PRs (#4613, #4616, #4647). These PRs were inadvertently squashed into a single commit `48eb749` titled after #4647 only. - The comment reflects the `--force` → `--auto-approve` rename from #4755. - Add a `NEXT_CHANGELOG.md` entry for `auth logout` under the CLI section. - Remove `Hidden: true` from the logout command so it appears in `databricks auth -h` and tab completion. - Improve the command's long description to: - Document that token cleanup only applies to profiles created by `databricks auth login` - Note that logging out of one profile does not affect others sharing the same cached token - Condense the numbered items (drop the redundant `--auto-approve` item since it's already mentioned in items 1 and 2; fold `--delete` into a single item) ## Why The `auth logout` feature was implemented across three stacked PRs (#4613, #4616, #4647) that were squashed into one commit on merge. The commit title only references the last PR ("Extract shared SelectProfile helper"), so `auth logout` itself has no changelog entry and no git-blame traceability. This followup restores that context, unhides the command for users, and adds the missing changelog entry. ## Tests No functional changes; existing unit and acceptance tests for `auth logout` continue to pass. --------- Co-authored-by: simon <simon.faltum@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--forceflag with--auto-approve, matching the pattern used bybundle deploy,bundle destroy, and other commands.--auto-approvedirectly on theauth logoutcommand instead of relying on an unregistered global--yesflag.--profileflag onauth logout— read the value from the shared flag already available on the command tree.--auto-approvebehavior.Why
The
--forceflag was specific toauth logout. Switching to--auto-approvealigns with the rest of the CLI's confirmation-skip pattern (bundle deploy --auto-approve,bundle destroy --auto-approve, etc.).auth logoutwas defining its own--profileflag, overriding the global one. Removing it and defaulting to the root behavior keeps UX aligned with other commands and removes a duplicate flag definition that can drift over time.Tests
go test ./cmd/auth -run TestLogout -count=1go test ./acceptance -run TestAccept/cmd/auth/logout -test.v