Uh oh!
There was an error while loading. Please reload this page.
Use bash as the default shell for SSH connect sessions - #5002
Open
anton-107 wants to merge 2 commits into
Open
Conversation
The default login shell on Databricks compute images is /bin/sh. This change ensures users get bash in two ways: 1. Client-side: when no remote command is specified, explicitly request /bin/bash -l with PTY allocation instead of relying on the default login shell from /etc/passwd. 2. Server-side: attempt to update /etc/passwd to set bash as the login shell before starting sshd, which also covers IDE connections (VS Code, Cursor) that manage their own SSH sessions. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
pietern
reviewed
Apr 17, 2026
| return fmt.Errorf("user %s not found in %s", username, passwdPath) | ||
| } | ||
| return os.WriteFile(passwdPath, []byte(strings.Join(result, "\n")+"\n"), 0o644) |
Contributor
There was a problem hiding this comment.
I think this will always fail. The repl user is not root.
It might be possible with usermod if it is setuid but I'm not sure about that.
eng-dev-ecosystem-bot
commented
Jun 11, 2026
Collaborator
Commit: 7c1543e
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 32 slowest tests (at least 2 minutes):
|
3 tasks
Chambras pushed a commit
to Chambras/newDatabrickscli
that referenced
this pull request
Jul 6, 2026
…atabricks#5687) ## Summary When `databricks ssh connect` is run with no trailing command, the CLI now explicitly launches a login `bash` shell over a PTY instead of relying on the compute image's default login shell (which is `/bin/sh` on Databricks compute images). This gives a consistent, predictable interactive shell. - Interactive (no args): appends `-t` and runs `command -v bash >/dev/null 2>&1 && exec bash -l || exec "${SHELL:-/bin/sh}" -l`. Graceful fallback to `$SHELL`/`/bin/sh` if bash is absent. - Non-interactive (`databricks ssh connect ... -- ls -la`): unchanged — the user's command is passed verbatim with no PTY/bash wrapper. This supersedes databricks#5002. That PR also tried to set bash as the login shell server-side by editing `/etc/passwd`, which @pietern correctly pointed out can never work — the `repl` user is not root. That approach is dropped; this change is purely client-side. Forcing bash inside the IDE (VS Code/Cursor) terminal is intentionally out of scope and tracked separately. Logic is isolated in a new `buildRemoteShellArgs` helper to keep the change small and unit-testable. ## Test plan - [x] `go test ./experimental/ssh/internal/client/` — new `TestBuildRemoteShellArgs` covers interactive + passthrough cases. - [x] Existing `acceptance/ssh/connection/` test exercises the non-interactive path (regression guard) and is unchanged. - [ ] Manual: `databricks ssh connect --cluster=<id>` opens a bash prompt (`echo $0`); `databricks ssh connect --cluster=<id> -- ls -la` still works. Jira: DECO-27476
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawnSSHClientnow explicitly runs/bin/bash -lwith-tfor PTY allocation instead of relying on the default login shell from/etc/passwd(which is/bin/shon Databricks compute images)./etc/passwdto set bash as the login shell for the current user. This covers IDE connections (VS Code, Cursor) that manage their own SSH sessions and don't go throughspawnSSHClient./etc/passwdcan't be modified.Test plan
databricks ssh connect --cluster=<id>opens a bash shell (tested manually)databricks ssh connect --cluster=<id> -- ls -lastill works (additional args passthrough)This pull request was AI-assisted by Isaac.