Uh oh!
There was an error while loading. Please reload this page.
Fix missing plugin name prefix in --set hint for apps init - #5089
Merged
Conversation
pkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 27, 2026 09:27
6b00d34 to
8d5146aComparepkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 27, 2026 11:47
8d5146a to
5cd2432Comparepkosiec
marked this pull request as ready for review
April 27, 2026 11:47
pkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 28, 2026 07:58
5cd2432 to
eff0b4cComparepkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 28, 2026 14:27
eff0b4c to
3d18c83Comparecalvarjorge
approved these changes
Apr 29, 2026
pkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 29, 2026 13:12
3d18c83 to
ae2ecf7Comparepkosiec
enabled auto-merge
April 29, 2026 13:12
pkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 30, 2026 07:36
ae2ecf7 to
93edb9dComparepkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
April 30, 2026 14:57
93edb9d to
a20fc01Comparepkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
May 4, 2026 12:30
a20fc01 to
844ffe5Comparepkosiec
disabled auto-merge
May 4, 2026 12:40
The validation error for missing required resources suggested `--set postgres.branch=value` but the actual format requires `--set lakebase.postgres.branch=value` (plugin.resourceKey.field). Add `PluginName` to the `Resource` struct and include it in the error message so the hint matches what `parseSetValues` expects.
pkosiecforce-pushed
the
fix/apps-init-set-hint-missing-plugin-prefix
branch
from
May 4, 2026 12:43
844ffe5 to
75b12abCompareMarioCadenas
approved these changes
May 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
5 tasks
denik pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - The validation error for missing required resources suggested `--set postgres.branch=value`, but the `--set` format requires three parts: `plugin.resourceKey.field`. The correct hint is `--set lakebase.postgres.branch=value`. - Added `PluginName` field to the `Resource` struct (populated during `CollectResources`/`CollectOptionalResources`) and included it in the error message. Thanks to @philip for spotting this bug! ## Test plan - [x] Existing `TestParseSetValues*` tests pass - [x] `libs/apps/manifest` tests pass This pull request and its description were written by Isaac.
TanishqDatabricks pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
…ricks#5089) ## Summary - The validation error for missing required resources suggested `--set postgres.branch=value`, but the `--set` format requires three parts: `plugin.resourceKey.field`. The correct hint is `--set lakebase.postgres.branch=value`. - Added `PluginName` field to the `Resource` struct (populated during `CollectResources`/`CollectOptionalResources`) and included it in the error message. Thanks to @philip for spotting this bug! ## Test plan - [x] Existing `TestParseSetValues*` tests pass - [x] `libs/apps/manifest` tests pass This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--set postgres.branch=value, but the--setformat requires three parts:plugin.resourceKey.field. The correct hint is--set lakebase.postgres.branch=value.PluginNamefield to theResourcestruct (populated duringCollectResources/CollectOptionalResources) and included it in the error message.Thanks to @philip for spotting this bug!
Test plan
TestParseSetValues*tests passlibs/apps/manifesttests passThis pull request and its description were written by Isaac.