Uh oh!
There was an error while loading. Please reload this page.
Make auto-generated files non-executable (set mode to 0644) - #5423
Merged
Conversation
genkit writes its generated output with mode 0755 (openapi/genkit sync.go and render.go), but the execute bit is meaningless for Go sources and a GitHub Actions workflow YAML. Normalize the generated command files plus tagging.yml and tagging.py to 0644 so they match every other workflow file and stop producing spurious mode diffs on regeneration. Co-authored-by: Isaac
janniklasrosetemporarily deployed
to
test-trigger-is
June 3, 2026 14:13 — with 
GitHub Actions
Inactive
janniklasrosetemporarily deployed
to
test-trigger-is
June 3, 2026 14:13 — with GitHub Actions
Inactive
Collaborator
Commit: a9d7371
22 interesting tests: 15 SKIP, 7 KNOWN
Top 28 slowest tests (at least 2 minutes):
|
janniklasrosetemporarily deployed
to
test-trigger-is
June 11, 2026 12:47 — with GitHub Actions
Inactive
janniklasrosetemporarily deployed
to
test-trigger-is
June 11, 2026 12:47 — with GitHub Actions
Inactive
Remove comment explaining file permissions for generated .go files.
janniklasrosetemporarily deployed
to
test-trigger-is
June 11, 2026 12:48 — with GitHub Actions
Inactive
janniklasrosetemporarily deployed
to
test-trigger-is
June 11, 2026 12:48 — with GitHub Actions
Inactive
pietern
approved these changes
Jun 11, 2026
pietern
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
Can you reflow/rephrase the PR summary before merge?
janniklasrose
enabled auto-merge
June 11, 2026 12:56
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jun 11, 2026
Collaborator
Commit: 3855a11
530 interesting tests: 440 MISS, 44 FAIL, 27 RECOVERED, 10 KNOWN, 4 PANIC, 3 flaky, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Source files should not be executable files.
genkitused to write its generated output with mode0755. Since #5484 we own the file mode inside the CLI repo so files will remain 0644 after flipping them to in this PR.Tests
CI
Co-authored-by: Isaac