Uh oh!
There was an error while loading. Please reload this page.
testserver: materialize postgres project status defaults - #5430
Merged
Conversation
A cloud run of the postgres_projects/purge_on_delete acceptance test (added in #5414) showed that the backend materializes default_endpoint_settings (1/1/86400s) and history_retention_duration (604800s) in the project status even when the spec omits them. The local testserver left these empty, diverging from cloud. PostgresProjectCreate now fills in these backend defaults when the spec doesn't provide them, with any spec-provided values overriding field-by-field. Co-authored-by: Isaac
eng-dev-ecosystem-bot
commented
Jun 4, 2026
Collaborator
Commit: ff9138f |
pietern
enabled auto-merge
June 4, 2026 10:06
andrewnester
approved these changes
Jun 4, 2026
eng-dev-ecosystem-bot
commented
Jun 4, 2026
Collaborator
Commit: 0cbdd49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cloud run of the
postgres_projects/purge_on_deleteacceptance test (added in #5414) showed that the backend materializesdefault_endpoint_settings(1/1/86400s) andhistory_retention_duration(604800s) in the project status even when the spec omits them. The local testserver left these empty, diverging from cloud.PostgresProjectCreatenow fills in these backend defaults when the spec doesn't provide them, with any spec-provided values overriding field-by-field. This brings the local test in line with the cloud golden output.This pull request and its description were written by Isaac.