Uh oh!
There was an error while loading. Please reload this page.
acc: update postgres goldens and testserver for new top-level ID fields - #5640
Merged
Conversation
The SDK bump to v0.147.0 (#5636) added top-level ID fields (project_id, branch_id, endpoint_id, database_id, role_id, catalog_id) to the postgres resource types, which the real Lakebase GET APIs now return. This broke every postgres acceptance test on cloud with golden-file mismatches. Regenerated the affected goldens against cloud, and taught the testserver to emit the same top-level IDs on create so local runs match cloud. Synced tables are unaffected. Co-authored-by: Isaac
eng-dev-ecosystem-bot
commented
Jun 18, 2026
Collaborator
Integration test reportCommit: f951200
21 interesting tests: 14 SKIP, 7 KNOWN
Top 20 slowest tests (at least 2 minutes):
|
anton-107
approved these changes
Jun 18, 2026
eng-dev-ecosystem-bot
commented
Jun 18, 2026
Collaborator
Integration test reportCommit: 3ecee64
446 interesting tests: 417 MISS, 9 KNOWN, 5 RECOVERED, 5 flaky, 4 FAIL, 4 PANIC, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK bump to v0.147.0 (#5636) added top-level ID fields (
project_id,branch_id,endpoint_id,database_id,role_id,catalog_id) to the postgres resource types, which the real Lakebase GET APIs now return. This broke every postgres acceptance test on cloud with golden-file mismatches.Regenerated the affected goldens against cloud, and taught the testserver to emit the same top-level IDs on create so local runs match cloud. Synced tables are unaffected.
Verified: postgres acceptance suite passes both on cloud (
-update) and locally, testserver unit tests pass, lint clean.This pull request and its description were written by Isaac.