Uh oh!
There was an error while loading. Please reload this page.
Read postgres IDs from top-level response field - #5642
Merged
Conversation
The SDK bump to v0.147.0 (#5636) added top-level ID fields (project_id, branch_id, endpoint_id, database_id, role_id) to the postgres resource types, which the real Lakebase GET APIs now return. The direct engine make*Remote helpers previously dug the ID out of the status subobject; read the top-level field directly instead. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 268c9d6
21 interesting tests: 13 SKIP, 7 KNOWN, 1 RECOVERED
|
denik
reviewed
Jun 29, 2026
denik
left a comment
Contributor
There was a problem hiding this comment.
The SDK bump to v0.147.0 (#5636) added top-level ID fields that the Lakebase GET APIs now return, making the status indirection unnecessary.
Did SDK bump added those fields or started to populate them?
If added, should we remove them from config and state struct?
type PostgresRoleConfig struct {
postgres.RoleRoleSpec
// RoleId is the user-specified ID for the role (becomes part of the hierarchical name).
// This is specified during creation and becomes part of Name: "projects/{project_id}/branches/{branch_id}/roles/{role_id}"
RoleId string `json:"role_id"`
// Parent is the branch containing this role. Format: "projects/{project_id}/branches/{branch_id}"
Parent string `json:"parent"`
}
// when parent comes from a resource reference.
type PostgresRoleState struct {
postgres.RoleRoleSpec
// RoleId is the leaf id, matching the user-facing config.
RoleId string `json:"role_id"`
pietern
commented
Jun 29, 2026
ContributorAuthor
They're in the GET response at the top level. Those include the The |
pietern
enabled auto-merge
June 29, 2026 10:56
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Read the top-level ID field directly in the postgres
make*Remotehelpers instead of digging it out ofstatus.Why
The SDK bump to v0.147.0 (#5636) added top-level ID fields that the Lakebase GET APIs now return, making the
statusindirection unnecessary. Example API docs: https://docs.databricks.com/api/workspace/postgres/getprojectThis pull request and its description were written by Isaac.