Uh oh!
There was an error while loading. Please reload this page.
direct: test StateType/RemoteType JSON round-trip; fix found issues - #5681
Merged
Conversation
…elds Add round-trip tests ensuring StateType and RemoteType survive json.Marshal -> json.Unmarshal, the path state and plan remote_state take. Fixes VectorSearchEndpointRemote (endpoint_uuid) and MlflowModelRemote (model_id), which embedded an SDK type with its own MarshalJSON but lacked their own, so the promoted marshaler silently dropped the field. Co-authored-by: Isaac
The dashboards fixture used []map[string]any for serialized_dashboard, a shape JSON/dyn decoding never produces (it yields []any). Use []any so the value round-trips to the same concrete type, letting the round-trip test assert exact equality instead of filtering JSON-equal differences. Co-authored-by: Isaac
Adds a dedicated RemoteType round-trip test symmetric with TestStateTypeRoundTrip. Since there is no per-RemoteType fixture, it fills every field with a non-zero value via reflection, so a dropped wrapper field is always observable (non-zero before, zero after) regardless of which fields a realistic value populates. Complements the concrete-value check in testCRUD. Co-authored-by: Isaac
Renames to a TestRoundtrip<Mode><Type> convention: - TestRoundtripFixtureStateType (was TestStateTypeRoundTrip) - TestRoundtripAllFieldsStateType (new) - TestRoundtripAllFieldsRemoteType (was TestRoundtripRemoteType) Factors the synthetic all-fields round-trip into a shared helper driven by a type accessor. InputType is intentionally omitted: it is never serialized via encoding/json (the bundle config layer uses dyn), so a json round-trip would fail by design for resources whose config structs lack a MarshalJSON. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: a2b2fca
Top 1 slowest tests (at least 2 minutes):
|
denik
enabled auto-merge
June 22, 2026 15:54
pietern
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct-engine resources persist their StateType to the state file and emit RemoteType in the plan's
remote_statefield, both viaencoding/json. A wrapper that embeds an SDK type with its ownMarshalJSONbut omits its own silently drops the wrapper's extra fields. Nothing tested this.The same bug class was fixed manually in #5672 (
role_id); these tests turn it into a guard across every resource.Adds round-trip tests and fixes two resources that had this bug:
VectorSearchEndpointRemotedroppedendpoint_uuidMlflowModelRemotedroppedmodel_idBoth fields carry the numeric ID the permissions API needs.
Tests:
TestRoundtripFixtureStateType— StateType round-trip on a realistic per-resource fixtureTestRoundtripAllFieldsStateType/TestRoundtripAllFieldsRemoteType— synthetic all-fields round-trip, so a dropped field is always observable regardless of fixture coveragetestCRUDInputType is intentionally not covered in this PR - many issues found but it is never serialized via
encoding/json(the bundle config layer uses dyn).This pull request and its description were written by Isaac.