Uh oh!
There was an error while loading. Please reload this page.
postgres: Support purge_on_delete on postgres_branches - #5801
Merged
Conversation
Co-authored-by: Isaac
# Conflicts: # libs/structs/structwalk/walktype_test.go
The dyn->typed ForceSendFields routing only handled one level of struct embedding. When a field declared in an SDK spec embedded two levels deep (e.g. PostgresProject -> PostgresProjectConfig -> ProjectSpec) was set to its zero value, its name was recorded in the wrong struct's ForceSendFields. The direct engine then failed to serialize the plan state with "field X cannot be found in struct Y". Route each field's ForceSendFields entry to the struct that actually declares it, at any embedding depth. This affected postgres_projects (enable_pg_native_login: false), postgres_branches, and postgres_endpoints (replace_existing: false). Terraform was unaffected (it serializes via dyn, not the SDK marshaler). Add a unit regression test for the deep-embedding case and a systemic guard that round-trips every registered resource type's zero-value fields, so any future resource using the embedded-spec wrapper pattern is covered automatically. Co-authored-by: Isaac
Adds support for purge_on_delete on Lakebase postgres_branches so bundles can hard-delete a branch on destroy. The flag is passed to the DeleteBranch API call as ?purge=true; when unset, the backend performs a soft delete that can be undone within the branch's retention window. The field is input-only: it is not modeled by the backend resource for branches, and the GET API never returns it. We store it in state purely so DoDelete can apply it on destroy. PrepareState preserves input.ForceSendFields so the structdiff comparison distinguishes "explicit false" from the fictional remote zero, and DoUpdate strips purge_on_delete from the API field mask so a state-only flip doesn't fire an unnecessary remote write. Acceptance tests are direct-engine only for now; the Terraform provider already supports the field but the provider bump that exposes it to DABs has not landed. Co-authored-by: Isaac
# Conflicts: # NEXT_CHANGELOG.md
Bump the pinned Databricks Terraform provider from v1.118.0 to v1.120.0, regenerate bundle/internal/tf/schema (and its ProviderVersion/checksums), and refresh the affected acceptance goldens. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
# Conflicts: # bundle/terraform_dabs_map/generated.go
Co-authored-by: Isaac
The tf-bump merge (provider 1.120.0) exposes purge_on_delete on databricks_postgres_branch to DABs, so the contrast test now runs on terraform too. The destroy purge contrast is identical across engines (unified out.requests.destroy.json); only the branch-create body diverges (Terraform sends parent in the body, direct as a query param), so the deploy requests are split per-engine. Co-authored-by: Isaac
Co-authored-by: Isaac
…-delete # Conflicts: # NEXT_CHANGELOG.md
Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 6988f94
10 interesting tests: 4 RECOVERED, 4 SKIP, 2 flaky
Top 4 slowest tests (at least 2 minutes):
|
…-delete # Conflicts: # NEXT_CHANGELOG.md # libs/dyn/convert/struct_info.go # libs/dyn/convert/to_typed.go
janniklasrose
approved these changes
Jul 8, 2026
Comment on lines
+39
to
+40
| >>> get_purge | ||
| json.state.resources.postgres_branches.branch.state.purge_on_delete = false; |
Contributor
There was a problem hiding this comment.
why does it remain in state after removing, when before adding it was not present?
pietern
enabled auto-merge
July 9, 2026 07:14
github-merge-queueBot
removed this pull request from the merge queue due to a conflict with the base branch
Jul 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Jul 9, 2026
## Release v1.7.0 ### CLI * An explicitly selected profile (`--profile` or a bundle's `workspace.profile`) now takes precedence over auth environment variables (`DATABRICKS_HOST`, `DATABRICKS_TOKEN`, etc.) instead of being silently shadowed by them; env vars still fill auth fields the profile leaves empty ([#5096](#5096)). * Fix intermittent crashes when processing pages from API calls ([#5815](#5815)). ### Bundles * direct: add basic version of job_runs resource (experimental) ([#5603](#5603)). * Fix permissions added to a job or pipeline by a Python (PyDABs) mutator failing to deploy with "must have exactly one owner"; the deploying identity is now set as owner, matching resources whose permissions are declared in YAML ([#5821](#5821)). * Remove duplicate enum values for jsonschema.json ([#5839](#5839)). * direct: volumes: support `volume_path` property ([#5550](#5550)). * direct: Fix deploy bug when a `postgres_projects`, `postgres_branches`, or `postgres_endpoints` field is set to its zero value (e.g. `enable_pg_native_login: false`, `replace_existing: false`) ([#5782](#5782)). * `bundle run --only` help now documents the `+` modifier syntax: prefix a task key with `+` to also run its upstream tasks, or suffix it with `+` for downstream tasks ([#5760](#5760)). * direct: Recognize UC-managed catalog and schema property defaults to avoid unnecessary drift ([#5865](#5865) & [#5870](#5870)). * Fix `bundle deploy --select <resource>` skipping the resource's grants and permissions; they are now applied as part of the selected resource ([#5852](#5852)). * Support `purge_on_delete: true` on `postgres_branches` so bundles can hard-delete a Lakebase branch on destroy (skipping the soft-delete retention window) ([#5801](#5801)). * Support `replace_existing: true` on `postgres_databases` and `postgres_roles` so bundles can take over a database or role that already exists on a Lakebase branch instead of failing with `ALREADY_EXISTS` ([#5803](#5803)). ### Dependency updates * Bump databricks-sdk-go to v0.154.0 ([#5855](#5855)). * Bump terraform-provider to 1.121.0 ([#5857](#5857)). * Bump OpenTelemetry dependencies to v1.44.0 to address [CVE-2026-41178](GHSA-5wrp-cwcj-q835) ([#5873](#5873)).
eng-dev-ecosystem-bot
commented
Jul 9, 2026
Collaborator
Integration test reportCommit: 91adbd6
45 interesting tests: 20 FAIL, 17 flaky, 5 RECOVERED, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
purge_on_deleteto Lakebasepostgres_branches, mirroringpostgres_projects(#5414). Whentrue, destroy callsDeleteBranchwith?purge=true(hard delete); otherwise the branch is soft-deleted and recoverable within its retention window.The flag is input-only, kept in state so
DoDeletecan apply it on destroy.DoUpdatestrips it from the field mask so toggling it is a state-only refresh.Acceptance tests assert the
?purge=truevs plainDELETEcontrast on both engines.This pull request and its description were written by Isaac.