Uh oh!
There was an error while loading. Please reload this page.
Merge permissions/grants invariant configs into their base configs - #5809
Merged
Conversation
The invariant configs had separate base and *_with_permissions/*_with_grants variants that differed only by an appended permissions or grants block. Fold the block into the base config and drop the variant for jobs, database instances, model serving endpoints, schemas, and secret scopes. model is left as a separate model/model_with_permissions pair: continue_293 deploys first with CLI v0.293.0, which cannot deploy model permissions (see its no_model_with_permissions exclude, PR #4941). Merging permissions into model.yml.tmpl would force excluding it from continue_293 and lose base-model continue-from-0.293.0 coverage. The other five resources have no such old-version limitation. Co-authored-by: Isaac
eng-dev-ecosystem-bot
commented
Jul 2, 2026
Collaborator
Integration test reportCommit: b1677c3
23 interesting tests: 13 SKIP, 10 RECOVERED
Top 5 slowest tests (at least 2 minutes):
|
denik
enabled auto-merge
July 2, 2026 16:24
shreyas-goenka
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The invariant configs had separate base and
*_with_permissions/*_with_grantsvariants that differed only by an appended permissions or grants block. Fold the block into the base config and drop the variant for jobs, database instances, model serving endpoints, schemas, and secret scopes.modelis left as a separatemodel/model_with_permissionspair:continue_293deploys first with CLI v0.293.0, which cannot deploy model permissions (see itsno_model_with_permissionsexclude, #4941). Merging permissions intomodel.yml.tmplwould force excluding it fromcontinue_293and lose base-model continue-from-0.293.0 coverage. The other five resources have no such old-version limitation.This pull request and its description were written by Isaac.