Uh oh!
There was an error while loading. Please reload this page.
acc: support DATABRICKS_TEST_SKIPLOCAL=withchanged - #5844
Merged
Conversation
New mode re-enables Local tests that are added or changed on the current branch, so a skiplocal cloud run still exercises the tests this PR touches. Accepted values: "true" (skip all Local tests, previous behaviour), "withchanged" (skip Local except changed/added on this branch), absent/empty (disabled). Any other value hard-fails the test run instead of being silently ignored. Detects changed tests via git diff --name-status --merge-base (one call, same approach as tools/lintdiff.py), caps at 50 tests (added-first), and batches the script-existence check at the merge base into a single git ls-tree call. Taskfile: test-update-aws uses =true, integration-short-skiplocal uses =withchanged. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
Collaborator
Integration test reportCommit: e6f0b57
8 interesting tests: 4 SKIP, 2 KNOWN, 1 RECOVERED, 1 flaky
Top 10 slowest tests (at least 2 minutes):
|
…s only Co-authored-by: Isaac
Co-authored-by: Isaac
…rule Co-authored-by: Isaac
Co-authored-by: Isaac
janniklasrose
approved these changes
Jul 8, 2026
| // touched but not yet committed, which breaks the "touch a config, run the | ||
| // test" local dev workflow (same reason lintdiff.py uses --merge-base). | ||
| func selectChangedLocalTests(testDirs map[string]bool) map[string][]string { | ||
| out, _ := exec.Command("git", "diff", "--name-status", "--merge-base", "-M", "origin/main").Output() |
Contributor
There was a problem hiding this comment.
how does this work in local with committed, staged, and unstaged changes?
ContributorAuthor
There was a problem hiding this comment.
all except untracked will be included
| for line := range strings.SplitSeq(diff, "\n") { | ||
| fields := strings.Split(line, "\t") | ||
| if len(fields) < 2 { |
Contributor
There was a problem hiding this comment.
can you extract 2 as magic constant with name that makes sense? Also used above in testDirForFile
ContributorAuthor
There was a problem hiding this comment.
'2' here and '2' above are two different twos.
This 2 is very local to code below, making a constant somewhere else won't improve readability.
…ed changes Co-authored-by: Isaac
Co-authored-by: Isaac
eng-dev-ecosystem-bot
commented
Jul 8, 2026
Collaborator
Integration test reportCommit: 985f8f8
30 interesting tests: 21 flaky, 3 KNOWN, 2 FAIL, 2 RECOVERED, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
withchangedmode: skipsLocal=truetests liketruedoes, but re-enables any test added or changed on this branch.Wire into
integration-short-skiplocalso PR cloud runs exercise the tests they touch.Why
We should run relevant tests on cloud on PRs. The tests that were added by PR are highly relevant. The tests that were modified by PR are probably relevant as well.