Uh oh!
There was an error while loading. Please reload this page.
Direct engine fixes - #5864
Merged
Merged
Conversation
Editing a warehouse restarts it (the Edit API returns a WaitGetWarehouseRunning waiter), so DoUpdate must reconcile the started/stopped decision from RUNNING rather than the stale pre-plan state. Without this a redeploy with lifecycle.started=false hung waiting for STOPPED because no Stop was ever issued after the Edit. Adds an acceptance test covering the edit + started=false path.
DoRead fetches with IncludeAliases=false and aliases live on model versions via a separate API, so GET never echoes them back. A config that sets aliases reported a perpetual in-place update and never converged. Classify aliases as ignore_remote_changes/input_only. Adds an acceptance test that deploys a model with aliases, edits the comment, and asserts the re-plan is a no-op.
Collaborator
Integration test reportCommit: 750e7a8
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 10 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jul 14, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…on cloud nightly Cite the SDK contract (Edit waits for RUNNING via WaitGetWarehouseRunning) in the DoUpdate comment and the acceptance script, addressing review feedback asking where the "Edit restarts the warehouse" behaviour is documented. Switch the lifecycle-started-edit test from Cloud=false to CloudSlow=true so it runs on cloud in the nightly matrix, confirming the real Edit behaviour without reintroducing per-PR warehouse-start timeouts.
Merging main brought in the newer out.test.toml generator that emits GOOSOnPR.darwin/windows. Regenerate the two test configs added in this PR so the generated-files check passes.
eng-dev-ecosystem-bot
commented
Jul 14, 2026
Collaborator
Integration test reportCommit: 18946ec
32 interesting tests: 19 flaky, 6 FAIL, 4 KNOWN, 2 SKIP, 1 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two direct-engine deploy bugs found via invariant fuzzing (#5686):
WaitGetWarehouseRunningwaiter), soDoUpdatenow reconciles the start/stop decision from the post-edit RUNNING state instead of the stale pre-plan state. A redeploy withlifecycle.started=falseno longer hangs waiting for STOPPED.registered_modelsalias drift:DoReadfetches withIncludeAliases=falseand aliases live on model versions via a separate API, so GET never echoes them back. A config that setaliasesreported a perpetualupdate; it's now classifiedignore_remote_changes/input_onlyso plans converge.Each fix includes an acceptance regression test.