Skip to content

test-only: Add cascade field to pipeline resource for destroy - #5874

Closed
andrewnester wants to merge 2 commits into
mainfrom
test/ronaldz-db/pipelines-destroy-cascade
Closed

test-only: Add cascade field to pipeline resource for destroy#5874
andrewnester wants to merge 2 commits into
mainfrom
test/ronaldz-db/pipelines-destroy-cascade

Conversation

@andrewnester

Copy link
Copy Markdown
Contributor

Used for testing: #5846

ronaldz-dband others added 2 commits July 9, 2026 10:50
Add a `cascade` field to the pipeline bundle resource that controls whether
destroying a pipeline also deletes its datasets (materialized views, streaming
tables, and views). When unset, the server default applies (cascade); set
`cascade: false` to retain the datasets on destroy.
The field is delete-time only: it is not part of the pipeline spec, so it is
never sent on create/update. The direct engine persists it in state (via a
PipelineState wrapper around CreatePipeline, mirroring the sql_warehouse
lifecycle pattern) and reads it at delete time, force-sending cascade so an
explicit false survives query-string omitempty (honored for query params as of
databricks-sdk-go v0.152.0). A cascade-only change is a state-only update with
no pipeline API call. cascade is classified input_only so it does not show
remote drift.
The terraform engine drops the field for now: the pinned provider has no such
attribute yet (pending terraform-provider-databricks#5860), so terraform-engine
support is a follow-up.
Co-authored-by: Isaac
@github-actions

Copy link
Copy Markdown
Contributor

Approval status: pending

/acceptance/bundle/ - needs approval

Files: acceptance/bundle/refschema/out.fields.txt
Suggested: @denik
Also eligible: @pietern, @janniklasrose, @shreyas-goenka, @anton-107, @lennartkats-db

/acceptance/pipelines/ - needs approval

5 files changed
Suggested: @lennartkats-db
Also eligible: @jefferycheng1, @kanterov

/bundle/ - needs approval

5 files changed
Suggested: @denik
Also eligible: @pietern, @janniklasrose, @shreyas-goenka, @anton-107, @lennartkats-db

General files (require maintainer)

Files: NEXT_CHANGELOG.md
Based on git history:

  • @denik -- recent work in bundle/direct/dresources/, ./, bundle/schema/

Any maintainer (@anton-107, @denik, @pietern, @shreyas-goenka, @simonfaltum, @renaudhartert-db, @janniklasrose) can approve all areas.
See OWNERS for ownership rules.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: b69096c

Run: 29006267709

Env💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
💚​aws linux4423010735:09
💚​aws windows4423210716:55
💚​aws-ucws linux443149916:23
💚​aws-ucws windows443169897:13
💚​azure linux4423010725:01
💚​azure windows4423210707:17
💚​azure-ucws linux443169886:27
💚​azure-ucws windows443189867:43
💚​gcp linux4422910745:37
💚​gcp windows4423110727:02
8 interesting tests: 4 RECOVERED, 4 SKIP
Test Nameaws linuxaws windowsaws-ucws linuxaws-ucws windowsazure linuxazure windowsazure-ucws linuxazure-ucws windowsgcp linuxgcp windows
💚​TestAccept💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
🙈​TestAccept/bundle/invariant/no_drift🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/ssh/connection🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
💚​TestFetchRepositoryInfoAPI_FromRepo💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
💚​TestFetchRepositoryInfoAPI_FromRepo/root💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
💚​TestFetchRepositoryInfoAPI_FromRepo/subdir💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
Top 10 slowest tests (at least 2 minutes):
durationenvtestname
6:18azure windowsTestAccept
6:11gcp windowsTestAccept
6:07aws-ucws windowsTestAccept
6:07azure-ucws windowsTestAccept
6:02aws windowsTestAccept
2:59aws linuxTestAccept
2:57gcp linuxTestAccept
2:55azure linuxTestAccept
2:51azure-ucws linuxTestAccept
2:50aws-ucws linuxTestAccept

Comment threadNEXT_CHANGELOG.md
@lennartkats-db

Copy link
Copy Markdown
Contributor

@andrewnester I suppose this is you exercising the tests for a slightly older version of #5846?

@andrewnester

Copy link
Copy Markdown
ContributorAuthor

Yes, exactly, this is just to run the tests as we can't run them from forks yet

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewnester@eng-dev-ecosystem-bot@lennartkats-db@ronaldz-db