Uh oh!
There was an error while loading. Please reload this page.
Add localenv/environments path owners - #5986
Merged
Merged
Conversation
*Why:* PRs touching `libs/localenv/`, `cmd/environments/`, and `acceptance/localenv/` currently fall through to the `*` rule and require a global maintainer's approval, even though these areas have dedicated owners. This blocks review turnaround on DB Connect / local-environment work. *What:* Add an OWNERS section granting per-path ownership of those three directories to @rugpanov, @rclarey, @anton-107, and @misha-db, so any of them can satisfy the `maintainer-approval` gate for changes in those areas. *Verification:* `node .github/scripts/owners.js validate` passes (all three paths exist; each rule resolves to 4 owners) and `node --test .github/scripts/owners.test.js .github/workflows/maintainer-approval.test.js` passes (64/64). Co-authored-by: Isaac
shreyas-goenka
approved these changes
Jul 20, 2026
rugpanov
enabled auto-merge
July 20, 2026 15:18
eng-dev-ecosystem-bot
commented
Jul 20, 2026
Collaborator
Integration test reportCommit: 4fda10d
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 1 slowest tests (at least 2 minutes):
|
eng-dev-ecosystem-bot
commented
Jul 20, 2026
Collaborator
Integration test reportCommit: 6ae9c71
18 interesting tests: 6 FAIL, 5 RECOVERED, 4 flaky, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PRs touching
libs/localenv/,cmd/environments/, andacceptance/localenv/currently fall through to the*rule in.github/OWNERSand therefore require a global maintainer's approval, even though these areas have dedicated owners. This adds review-turnaround friction on DB Connect / local-environment work (e.g. #5963).What
Adds an OWNERS section granting per-path ownership of those three directories to
@rugpanov,@rclarey,@anton-107, and@misha-db, so any of them can satisfy themaintainer-approvalgate for changes in those areas — matching the existing per-path pattern used for Labs and Pipelines.Verification
node .github/scripts/owners.js validatepasses (all three paths exist in the tree; each rule resolves to 4 owners; only the pre-existingteam:ai-trainingwarning remains).node --test .github/scripts/owners.test.js .github/workflows/maintainer-approval.test.jspasses (64/64).This pull request and its description were written by Isaac.