Uh oh!
There was an error while loading. Please reload this page.
Add bump-tf skill - #5990
Merged
Merged
Conversation
Codify the Terraform provider bump workflow as a user-invocable skill: bump the version constant in bundle/internal/tf/codegen/schema/version.go, regenerate the Go schema and the DABs<->TF field map via ./task, refresh acceptance goldens with a mandatory non-update verify pass that catches divergent engine variants, resolve schema-driven behavior changes (now-required or removed provider fields), and add a changelog fragment. The registry-workaround.md appendix documents the filesystem-mirror fallback for when the Terraform Registry has not yet indexed a freshly published release. Co-authored-by: Isaac
pietern
marked this pull request as ready for review
July 21, 2026 08:39
Collaborator
Integration test reportCommit: 3eaaf60
9 interesting tests: 4 RECOVERED, 4 SKIP, 1 flaky
Top 18 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Jul 21, 2026
| If codegen succeeded, ignore this file. | ||
| ## Fix: point Terraform at a local filesystem mirror |
Contributor
There was a problem hiding this comment.
have you seen this be needed?
denik
reviewed
Jul 21, 2026
| Everything else (`bundle/internal/tf/schema/*` including `root.go`, and `bundle/terraform_dabs_map/generated.go`) is generated from it, so the only file you hand-edit for the bump itself is `version.go`. | ||
| Do not edit the generated files, and do not touch the `databricks-tf-provider/...` version comment in `libs/testdiff/replacement.go` (the version is masked in acceptance output, so changing it is pure noise). | ||
| ## Steps |
Contributor
There was a problem hiding this comment.
Given very deterministic instructions, can the whole thing be a Python script? The skill can still be there but it runs the script and then debugs if it does not work (and improves the script further).
ContributorAuthor
There was a problem hiding this comment.
Probably true, but more investment. @janniklasrose confirmed this worked out of the box last week.
And we'll remove it with TF in a little while anyway.
pietern
enabled auto-merge
August 11, 2026 14:16
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a user-invocable
bump-tfskill that codifies the Terraform provider bump workflow: bump the version constant, regenerate the Go schema (./task generate-tf-schema) and the DABs/TF field map (./task generate-schema-map), refresh acceptance goldens with a mandatory non-update verify pass, resolve schema-driven behavior changes, and add a changelog fragment.Why
The bump has non-obvious steps that are easy to get wrong. The
-updateacceptance run can silently mask a real failure when a schema change makes the Terraform and direct engines diverge, so the skill requires a non-update verify pass to catch it. Capturing the workflow makes future bumps repeatable.Tests
Validated by running the skill hands-off in a fresh worktree to bump to v1.122.0. Its result was byte-identical on the important bits to the manually authored #5977, differing only in one equivalent fixture value and the changelog filename.
This pull request and its description were written by Isaac.