Uh oh!
There was an error while loading. Please reload this page.
Add bump-sdk skill - #5991
Merged
Merged
Conversation
Add a user-invocable bump-sdk skill that codifies the databricks-sdk-go bump workflow: resolve the SDK version (optionally from a Terraform provider's go.mod) and its paired .codegen/_openapi_sha, apply the bump, regenerate cli.json via genkit and all downstream artifacts, handle SDK breaking-change and acceptance-test fallout, verify, and add a changelog fragment. Consistent with the sibling bump-tf skill. Co-authored-by: Isaac
Collaborator
Integration test reportCommit: 416c7fc
11 interesting tests: 4 RECOVERED, 4 SKIP, 3 flaky
Top 18 slowest tests (at least 2 minutes):
|
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Two fixes from a rubric evaluation against the authoring skill: - Use `./task generate-schema-map` for the DABs<->TF field map instead of a raw `go test ... -update`, and drop the incorrect "the tasks don't cover it" claim (the task wraps exactly that test), matching the bump-tf skill. - Genericize the push-auth line: a shared skill should not hardcode an individual maintainer's gh handle. Co-authored-by: Isaac
janniklasrose
left a comment
Contributor
There was a problem hiding this comment.
tested this skill on #6098
The agent kept getting hung up on python 3.9 issues and uv not being installed, so some local tests were failing. We should improve the test harness or give it instructions to the agents here how to unblock itself
Uh oh!
There was an error while loading. Please reload this page.
- Resolve the latest SDK version when the user gives none, instead of prompting. - Write the spec SHA with `echo`, since `generate` reformats the file. - Run `./task lint` for the exhaustruct fallout, and `./task test-unit-root` for the unit suite. - Point at pr-checklist for the PR template, keeping only the bump-specific line. - Loosen the too-specific stacking example. Co-authored-by: Isaac
Add guidance so the agent installs `uv` (which provisions the pinned interpreter) instead of fighting an old system python3 when a pydabs task fails, per review feedback from testing on #6098. Co-authored-by: Isaac
janniklasrose
approved these changes
Aug 11, 2026
janniklasrose
enabled auto-merge
August 11, 2026 14:29
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add a user-invocable
bump-sdkskill that codifies the databricks-sdk-go bump workflow: resolve the SDK version (optionally from a Terraform provider'sgo.mod) and its paired.codegen/_openapi_sha, apply the bump, regenerate cli.json via genkit and all downstream artifacts, handle SDK breaking-change and acceptance-test fallout, verify, and add a changelog fragment.Why
The bump has non-obvious steps that are easy to get wrong. The SDK version and the OpenAPI spec SHA must move as a pair, and the
-updateacceptance run can silently mask a real failure when a schema change makes the Terraform and direct engines diverge, so the skill requires a non-update verify pass to catch it. Capturing the workflow makes future bumps repeatable and keeps it consistent with the siblingbump-tfskill.Tests
Validated by running the skill hands-off in a fresh worktree on
origin/main(Terraform provider already at v1.122.0, SDK not yet bumped) to bump to v0.160.0. Its result matched the manually authored #5982 on every substantive point (resolved versions and the source-code edits), differing only where the skill correctly defers a destructive test deletion to the user.This pull request and its description were written by Isaac.