Skip to content

Fix experiment create trace location - #5993

Merged
radakam merged 2 commits into
mainfrom
fix-experiment-create-trace-location
Jul 22, 2026
Merged

Fix experiment create trace location#5993
radakam merged 2 commits into
mainfrom
fix-experiment-create-trace-location

Conversation

@radakam

@radakamradakam commented Jul 21, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The test server's fake ExperimentCreate rebuilt the experiment field-by-field and dropped TraceLocation. Since it's immutable and the real GetExperiment echoes it back, the direct-engine diff saw local-present vs remote-absent and spuriously recreated the experiment on every plan/deploy. Fix: pass TraceLocation through.

Found by fuzz testing.

@radakam
Preserve trace_location on experiment create in test server
5ff8f06
The fake ExperimentCreate rebuilt the stored experiment field-by-field and
never copied TraceLocation from the request. TraceLocation is immutable and
the real GetExperiment echoes it back, so the direct-engine diff saw the
field as local-present vs remote-absent and spuriously recreated the
experiment on every subsequent plan/deploy.
Copy TraceLocation through so the fake mirrors backend behaviour.
@radakam
Shorten trace_location comment
50c0e74
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 50c0e74

Run: 29816357065

Env💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
💚​aws linux4422711273:31
💚​aws windows4422911253:53
💚​aws-ucws linux4431410443:54
💚​aws-ucws windows4431610424:37
💚​azure linux4422711263:02
💚​azure windows4422911243:51
💚​azure-ucws linux4431610414:20
💚​azure-ucws windows4431810394:25
💚​gcp linux4422611282:43
💚​gcp windows4422811263:17
8 interesting tests: 4 RECOVERED, 4 SKIP
Test Nameaws linuxaws windowsaws-ucws linuxaws-ucws windowsazure linuxazure windowsazure-ucws linuxazure-ucws windowsgcp linuxgcp windows
💚​TestAccept💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
🙈​TestAccept/bundle/invariant/no_drift🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/ssh/connection🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
💚​TestFetchRepositoryInfoAPI_FromRepo💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
💚​TestFetchRepositoryInfoAPI_FromRepo/root💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
💚​TestFetchRepositoryInfoAPI_FromRepo/subdir💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R💚​R
Top 2 slowest tests (at least 2 minutes):
durationenvtestname
2:17azure windowsTestAccept
2:07azure-ucws windowsTestAccept/bundle/deploy/mlops-stacks/DATABRICKS_BUNDLE_ENGINE=terraform

@radakam
radakam marked this pull request as ready for review July 21, 2026 09:48
@radakam
radakam added this pull request to the merge queueJul 21, 2026
@radakam
radakam removed this pull request from the merge queue due to a manual request Jul 21, 2026
@radakam
radakam added this pull request to the merge queueJul 22, 2026
Merged via the queue into main with commit aaa5477Jul 22, 2026
27 checks passed
@radakam
radakam deleted the fix-experiment-create-trace-location branch July 22, 2026 08:09
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: aaa5477

Run: 29902941383

Env❌​FAIL🟨​KNOWN🔄​flaky💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
❌​aws linux101852969875190:22
❌​aws windows121652911893269:31
🔄​azure linux342881911124:59
🔄​azure windows1262812929188:57
❌​gcp linux18422852917132:19
❌​gcp windows16422796935216:32
46 interesting tests: 20 FAIL, 19 flaky, 4 KNOWN, 2 SKIP, 1 RECOVERED
Test Nameaws linuxaws windowsazure linuxazure windowsgcp linuxgcp windows
🟨​TestAccept🟨​K🟨​K🔄​f💚​R🟨​K🟨​K
💚​TestAccept/bundle/invariant/no_drift💚​R💚​R💚​R💚​R💚​R💚​R
❌​TestAccept/bundle/resources/catalogs/basic✅​p❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/catalogs/basic/DATABRICKS_BUNDLE_ENGINE=direct✅​p❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/catalogs/with-schemas✅​p❌​F✅​p✅​p✅​p❌​F
❌​TestAccept/bundle/resources/catalogs/with-schemas/DATABRICKS_BUNDLE_ENGINE=direct✅​p❌​F✅​p✅​p✅​p❌​F
❌​TestAccept/bundle/resources/clusters/lifecycle-started-toggle✅​p✅​p✅​p✅​p❌​F✅​p
❌​TestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p❌​F✅​p
🔄​TestAccept/bundle/resources/dashboards/change-name✅​p🔄​f✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/dashboards/change-name/DATABRICKS_BUNDLE_ENGINE=direct✅​p🔄​f✅​p🔄​f✅​p✅​p
❌​TestAccept/bundle/resources/dashboards/change-serialized-dashboard✅​p✅​p✅​p✅​p❌​F✅​p
❌​TestAccept/bundle/resources/dashboards/change-serialized-dashboard/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p✅​p❌​F✅​p
❌​TestAccept/bundle/resources/grants/catalogs❌​F❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/grants/catalogs/DATABRICKS_BUNDLE_ENGINE=direct❌​F❌​F✅​p✅​p❌​F❌​F
🔄​TestAccept/bundle/resources/grants/registered_models✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/grants/registered_models/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p🔄​f✅​p✅​p
❌​TestAccept/bundle/resources/grants/schemas/change_privilege❌​F❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/grants/schemas/change_privilege/DATABRICKS_BUNDLE_ENGINE=direct❌​F❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/grants/schemas/duplicate_principals🔄​f🔄​f✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/grants/schemas/duplicate_principals/DATABRICKS_BUNDLE_ENGINE=direct🔄​f🔄​f✅​p✅​p❌​F❌​F
🔄​TestAccept/bundle/resources/grants/schemas/duplicate_privileges🔄​f✅​p✅​p✅​p✅​p✅​p
🔄​TestAccept/bundle/resources/grants/schemas/duplicate_privileges/DATABRICKS_BUNDLE_ENGINE=terraform🔄​f✅​p✅​p✅​p✅​p✅​p
🔄​TestAccept/bundle/resources/grants/schemas/empty_array🔄​f✅​p✅​p✅​p✅​p✅​p
🔄​TestAccept/bundle/resources/grants/schemas/empty_array/DATABRICKS_BUNDLE_ENGINE=direct🔄​f✅​p✅​p✅​p✅​p✅​p
❌​TestAccept/bundle/resources/grants/schemas/out_of_band_principal❌​F❌​F✅​p🔄​f❌​F❌​F
❌​TestAccept/bundle/resources/grants/schemas/out_of_band_principal/DATABRICKS_BUNDLE_ENGINE=direct❌​F❌​F✅​p✅​p❌​F❌​F
🔄​TestAccept/bundle/resources/grants/schemas/out_of_band_principal/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p🔄​f✅​p✅​p
❌​TestAccept/bundle/resources/grants/volumes❌​F❌​F✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/grants/volumes/DATABRICKS_BUNDLE_ENGINE=direct❌​F❌​F✅​p✅​p❌​F❌​F
🔄​TestAccept/bundle/resources/model_serving_endpoints/basic✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/model_serving_endpoints/basic/DATABRICKS_BUNDLE_ENGINE=terraform✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/pipelines/update✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/pipelines/update/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/resources/postgres_roles/update🔄​f✅​p🙈​s🙈​s🙈​s🙈​s
🔄​TestAccept/bundle/resources/postgres_roles/update/DATABRICKS_BUNDLE_ENGINE=direct🔄​f✅​p
🔄​TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name💚​R💚​R🔄​f💚​R💚​R💚​R
🔄​TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name/DATABRICKS_BUNDLE_ENGINE=direct✅​p✅​p🔄​f✅​p✅​p✅​p
🙈​TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
❌​TestAccept/bundle/resources/volumes/uppercase-name❌​F🔄​f✅​p✅​p❌​F❌​F
❌​TestAccept/bundle/resources/volumes/uppercase-name/DATABRICKS_BUNDLE_ENGINE=direct❌​F🔄​f✅​p✅​p❌​F❌​F
🔄​TestAccept/bundle/select/basic✅​p✅​p✅​p🔄​f✅​p✅​p
🔄​TestAccept/bundle/select/basic/DATABRICKS_BUNDLE_ENGINE=direct/READPLAN=1✅​p✅​p✅​p🔄​f✅​p✅​p
🙈​TestAccept/ssh/connection🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestFetchRepositoryInfoAPI_FromRepo💚​R💚​R💚​R💚​R🟨​K🟨​K
🟨​TestFetchRepositoryInfoAPI_FromRepo/root💚​R💚​R💚​R💚​R🟨​K🟨​K
🟨​TestFetchRepositoryInfoAPI_FromRepo/subdir💚​R💚​R💚​R💚​R🟨​K🟨​K
Top 50 slowest tests (at least 2 minutes):
durationenvtestname
13:33gcp windowsTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
13:15aws windowsTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
12:50gcp windowsTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
12:23gcp linuxTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
11:38aws linuxTestAccept/bundle/config-remote-sync/multiple_resources/DATABRICKS_BUNDLE_ENGINE=terraform
11:29aws linuxTestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
10:11azure linuxTestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
9:36azure linuxTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
8:58gcp linuxTestAccept/bundle/config-remote-sync/multiple_resources/DATABRICKS_BUNDLE_ENGINE=direct
8:20azure windowsTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
7:54gcp linuxTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=terraform
7:45gcp linuxTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=direct
7:43azure linuxTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
7:41aws windowsTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=terraform
7:41azure linuxTestAccept/bundle/resources/clusters/resize-terminated-fallback/DATABRICKS_BUNDLE_ENGINE=direct
7:33aws linuxTestAccept/bundle/resources/apps/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
7:30aws linuxTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
7:20gcp windowsTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=terraform
7:19azure windowsTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
7:16aws linuxTestAccept/bundle/resources/clusters/deploy/data_security_mode/DATABRICKS_BUNDLE_ENGINE=direct
7:09gcp windowsTestAccept/bundle/resources/apps/lifecycle-started-omitted/DATABRICKS_BUNDLE_ENGINE=direct
7:05gcp linuxTestAccept/bundle/resources/clusters/deploy/local_ssd_count/DATABRICKS_BUNDLE_ENGINE=direct
7:03gcp linuxTestAccept/bundle/resources/clusters/deploy/update-after-create/DATABRICKS_BUNDLE_ENGINE=direct
6:58gcp linuxTestAccept/bundle/resources/clusters/deploy/simple/DATABRICKS_BUNDLE_ENGINE=direct
6:57azure windowsTestAccept/bundle/resources/models/basic/DATABRICKS_BUNDLE_ENGINE=terraform
6:53gcp windowsTestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
6:51aws windowsTestAccept/bundle/invariant/continue_293/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=volume_uppercase_name.yml.tmpl
6:51gcp linuxTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
6:50gcp windowsTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=direct
6:46aws windowsTestAccept/bundle/apps/job_permissions/DATABRICKS_BUNDLE_ENGINE=terraform
6:46aws windowsTestAccept/bundle/invariant/migrate/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=secret_scope.yml.tmpl
6:44gcp windowsTestAccept/bundle/resources/clusters/deploy/local_ssd_count/DATABRICKS_BUNDLE_ENGINE=direct
6:41gcp linuxTestAccept/bundle/config-remote-sync/multiple_resources/DATABRICKS_BUNDLE_ENGINE=terraform
6:31aws windowsTestAccept/bundle/resources/clusters/lifecycle-started/DATABRICKS_BUNDLE_ENGINE=direct
6:18aws windowsTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=direct
6:15aws linuxTestAccept/bundle/config-remote-sync/multiple_resources/DATABRICKS_BUNDLE_ENGINE=direct
6:11gcp windowsTestAccept/bundle/deploy/spark-jar-task/DATABRICKS_BUNDLE_ENGINE=terraform
6:11azure windowsTestAccept/bundle/resources/registered_models/basic/DATABRICKS_BUNDLE_ENGINE=direct
6:09aws windowsTestAccept/bundle/resources/postgres_branches/update_protected/DATABRICKS_BUNDLE_ENGINE=terraform
5:58azure windowsTestAccept/bundle/resources/models/basic/DATABRICKS_BUNDLE_ENGINE=direct
5:54azure windowsTestAccept/bundle/resources/pipelines/auto-approve/DATABRICKS_BUNDLE_ENGINE=terraform
5:52aws windowsTestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
5:45aws linuxTestAccept/bundle/resources/postgres_databases/update/DATABRICKS_BUNDLE_ENGINE=terraform
5:44aws windowsTestAccept/bundle/invariant/continue_293/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=volume.yml.tmpl
5:40azure windowsTestAccept/bundle/resources/clusters/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct
5:39aws windowsTestAccept/bundle/invariant/continue_293/DATABRICKS_BUNDLE_ENGINE=direct/INPUT_CONFIG=secret_scope.yml.tmpl
5:34aws linuxTestAccept/bundle/resources/postgres_roles/update/DATABRICKS_BUNDLE_ENGINE=direct
5:29azure windowsTestAccept/bundle/resources/secret_scopes/permissions/DATABRICKS_BUNDLE_ENGINE=direct
5:25azure windowsTestAccept/bundle/resources/experiments/basic/DATABRICKS_BUNDLE_ENGINE=terraform
5:19gcp windowsTestAccept/bundle/resources/apps/lifecycle-started-toggle/DATABRICKS_BUNDLE_ENGINE=direct

@radakamradakam mentioned this pull request Jul 23, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radakam@eng-dev-ecosystem-bot@pietern