Uh oh!
There was an error while loading. Please reload this page.
Fix never-converging job diff on reordered webhook notifications - #6060
Merged
Conversation
The Jobs API treats webhook_notifications.on_* lists as unordered sets and may return them in a different order than submitted. The direct engine compared these lists positionally (structdiff with no key func), so a stable server-side reordering produced a phantom diff that "bundle plan"/"bundle deploy" could never converge past. Add the job-, task-, and for_each-task-level webhook_notifications.on_* paths to ResourceJob.KeyedSlices(), keyed by id, so the diff is order-insensitive. This matches the existing pattern for depends_on.
denik
reviewed
Jul 24, 2026
Uh oh!
There was an error while loading. Please reload this page.
Deploys a job with webhook_notifications.on_* destinations, then uses edit_resource.py to reorder the remote lists (simulating the Jobs API returning them in a different order) and asserts bundle plan reports 0 to change. Without the KeyedSlices fix this plan shows 1 to change.
Collaborator
Integration test reportCommit: 9b1131e
8 interesting tests: 4 RECOVERED, 4 SKIP
Top 3 slowest tests (at least 2 minutes):
|
radakam
marked this pull request as ready for review
July 24, 2026 11:04
denik
approved these changes
Jul 30, 2026
denik
left a comment
Contributor
There was a problem hiding this comment.
Could you add changelog entry?
radakam
enabled auto-merge
July 30, 2026 08:13
Uh oh!
There was an error while loading. Please reload this page.
eng-dev-ecosystem-bot
commented
Jul 30, 2026
Collaborator
Integration test reportCommit: f496c89
22 interesting tests: 10 FAIL, 5 RECOVERED, 4 flaky, 2 SKIP, 1 KNOWN
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-taggingBot
added a commit
that referenced
this pull request
Aug 6, 2026
## Release v1.11.0 ### CLI * Fixed `databricks repos get/update/delete` failing with `object at path "..." is not a repo` for Git-CLI-enabled folders (currently in preview), which the workspace API reports as directories rather than repos ([#6181](#6181)). * Support `dbfs:/Skills/...` paths in `databricks fs` commands, routed to the Files API. ([#6147](#6147)) ### Bundles * For jobs where `ai_runtime_task.code_source_path` is a relative path to a local directory, the directory is now packaged into a tarball (honoring `.gitignore` and `sync.include`/`sync.exclude`), uploaded during deployment, and `code_source_path` is rewritten to the uploaded workspace path. ([#6110](#6110)) * Added JSON output to `bundle init`. Running `databricks bundle init <template> -o json` now reports the files the template wrote, relative to the output directory. This lets callers that pass `--output-dir` learn where the template materialized instead of assuming the output is a single directory named after the project. The default text output is unchanged. ([#6161](#6161)) * The terraform deployment engine is deprecated and will stop working in a future version of the CLI. Setting `bundle.engine: terraform` now emits a deprecation warning. See https://docs.databricks.com/aws/en/dev-tools/bundles/direct for how to migrate to the direct deployment engine. ([#6099](#6099)) * Fixed the direct deployment engine planning a spurious `create` for an empty `grants: []` list. Terraform records no grants resource for such a list, so `bundle plan` after `bundle deployment migrate` no longer reports an action for it. Emptying a previously deployed list still revokes the grants, after which the node is dropped from the deployment state instead of being reported as unchanged forever. ([#6039](#6039)) * Fixed `bundle generate` downloading notebooks found inside a folder without their file extension. They are now exported like top-level notebooks, so a Python notebook lands as `notebook.py` instead of an extensionless file ([#6144](#6144)). * direct: `webhook_notifications.on_*` destinations on jobs, tasks, and `for_each_task` are now compared as unordered sets. Previously the Jobs API returning these lists in a different order than submitted produced a phantom diff that `bundle plan` and `bundle deploy` could never converge past, reporting `1 to change` on every run ([#6060](#6060)). * Fixed a pipeline with `allow_duplicate_names: true` never converging on the direct engine: the field is only accepted on create/update and is never returned by the pipelines GET API, so every subsequent `bundle plan` reported the pipeline as a perpetual update. ([#6076](#6076)) * direct: A local change to an input-only field (one the API accepts on write but never returns on read, e.g. pipelines' `run_as` or external locations' `skip_validation`) is no longer silently skipped when the new value coincidentally matches the field's fabricated remote value. Previously such a change could hit the `remote_already_set` shortcut and be dropped from the plan. ([#6112](#6112)) * Revert usage of RedactiveSenstiveFields (added in [#5896](#5896), released in 1.10.0) which lead to incorrect behaviour (permanent drift) for duration field in Postgres resources ([#6179](#6179)). * Document postgres resource fields in the json schema ([#6164](#6164), [#6163](#6163)). * direct: Recreating a `vector_search_indexes` resource no longer fails with "Index ... is currently pending deletion" when the backend has not yet released the index name. The create is now retried until the name becomes available. ([#6143](#6143)) ### Dependency Updates * Bump `github.com/databricks/databricks-sdk-go` from v0.165.0 to v0.166.0. ([#6175](#6175)) * Upgrade Terraform provider to 1.124.0. ([#6174](#6174))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Jobs API treats
webhook_notifications.on_*destination lists as unordered sets and may return them in a different order than submitted. The direct engine diffed these lists positionally (structdiffwith no key func), so a stable server-side reorder produced a phantom diff thatbundle plan/bundle deploycould never converge past (1 to changeforever). This reproduces afterbundle deployment migrate, and on any direct deploy where the remote returns a different-but-valid permutation.Fix
Register the job-, task-, and
for_each_task-levelwebhook_notifications.on_*paths inResourceJob.KeyedSlices(), keyed byid, so the lists are compared as sets rather than by index — the same pattern already used fordepends_on.Tests
jobs/webhook-reorder-remote: deploys a job, reorders the remote lists viaedit_resource.py, and assertsbundle planreports0 to change. Verified it fails (1 to change) with the fix removed.for_each_taskwebhook paths.