Uh oh!
There was an error while loading. Please reload this page.
acc: merge repls.json into ACC_REPLS and move it out of the test directory - #6264
Merged
Conversation
Collaborator
Integration test reportCommit: cd69ff5
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Top 11 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Aug 13, 2026
| for line := range lines { | ||
| line = strings.TrimSpace(line) | ||
| if len(line) == 0 { | ||
| if len(line) == 0 || strings.HasPrefix(line, "{") { |
Contributor
There was a problem hiding this comment.
Is it possible for the user's replacement to start with {? Like if I am replacing something like {myjson...} with [MYJSON]?
ContributorAuthor
There was a problem hiding this comment.
Yes, and it was broken — the line was taken for a harness entry and the replacement was silently dropped. Fixed in 6c523a4: every line in the file is now a JSON object ("Old" for a harness regex, "Literal" for a value from a script), so nothing sniffs a prefix. The harness skips the lines it wrote by their count instead. selftest/acc_repls covers {"a": 1}, a value with a colon, and one with quotes and backslashes.
Written by Claude Code.
| return result | ||
| def add_repl(value, repl): |
Contributor
There was a problem hiding this comment.
Add an error if the repl starts with {?
ContributorAuthor
There was a problem hiding this comment.
Not needed anymore — those values work now, so an error would reject a legitimate one. See 6c523a4.
Written by Claude Code.
denikforce-pushed
the
denik/do-not-upload-outputs
branch
from
August 17, 2026 08:14
2f141ab to
c747d10Comparedenik
enabled auto-merge
August 17, 2026 08:18
github-merge-queueBot
removed this pull request from the merge queue due to failed status checks
Aug 17, 2026
Uh oh!
There was an error while loading. Please reload this page.
…ctory Both files were created inside the test directory, so bundle deploy uploaded them to the workspace. There is now a single file at $ACC_REPLS, outside the test directory: the harness writes its replacements there as one JSON object per line, add_repl.py appends "<value>:<NAME>" lines as before. Co-authored-by: Isaac
Every line is now a JSON object: "Old" for a regular expression from the harness,
"Literal" for a value added by add_repl.py. Previously the two kinds were told apart
by a leading "{", so a value starting with "{" was silently dropped.
The harness skips the lines it wrote itself by their count instead.
Co-authored-by: IsaacCo-authored-by: Isaac
The deploy summary from #5720 counts uploaded files, and repls.json was one of them. Co-authored-by: Isaac
denikforce-pushed
the
denik/do-not-upload-outputs
branch
from
August 17, 2026 09:57
c747d10 to
cd69ff5CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
denik added a commit
that referenced
this pull request
Aug 17, 2026
## Why Two tests assert `Files: N uploaded`, which is not stable on Windows: - `bundle/lifecycle/prevent-destroy` is the only test that redirects `bundle deploy` output away from `output.txt`, so nothing writes to `output.txt` between the two deploys. Its mtime stays put on Linux and macOS, but on Windows the last-write-time update on the still-open handle lands late and the file looks modified, giving `Files: 3` instead of `2`. Deterministic, both engines. - `bundle/artifacts/shell/cmd` only runs on Windows, so `-update` elsewhere skips it. #6264 took repls.json out of the synced tree and moved the four sibling shell tests from 6 to 5, leaving this one stale at 6. ## Changes Add `-qq` to those deploys. The count is noise in both: prevent-destroy asserts the `prevent_destroy` error, and shell/cmd asserts which shell ran the build via `out.shell.txt`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Both files were created inside the test directory, so bundle deploy uploaded them to the workspace. They also carried the same data in two formats: repls.json from the harness to diff.py, ACC_REPLS from the scripts back to the harness.
Having it in test directory made file count less stable in #5720
Changes
A single file at $ACC_REPLS, outside the test directory. Every line is one replacement encoded as a JSON object: "Old" for a regular expression from the harness, "Literal" for a value added by add_repl.py. Scripts no longer write the file directly - they use the new add_repl helper, which works under MSYS_NO_PATHCONV=1. diff.py and sort_lines.py --repl now apply the script replacements too.