Skip to content

Add changelog fragment when bumping the Go toolchain - #6271

Merged
pietern merged 4 commits into
mainfrom
go-toolchain-changelog
Aug 14, 2026
Merged

Add changelog fragment when bumping the Go toolchain#6271
pietern merged 4 commits into
mainfrom
go-toolchain-changelog

Conversation

@pietern

@pieternpietern commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The most recent Go toolchain bump (#6266) merged without a changelog entry, because the bump-go-toolchain workflow never emitted one and no one added it by hand.

  • Add the missing fragment for go1.26.6, with the PR link expanded.
  • Update the workflow to write a version-named fragment on every bump. The fragment is added as a follow-up commit after the PR is created, so it can reference the new PR number (([#N](.../pull/N))) — this is why it runs after Create pull request rather than before, and it keeps the entry ready for the planned lint that requires a PR link on fragments.

This pull request and its description were written by Isaac.

@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 03661bc

Run: 31803558814

Env🟨​KNOWN💚​RECOVERED🙈​SKIP✅​pass🙈​skipTime
🟨​aws linux31428611455:52
🟨​aws windows31428811434:52
🟨​azure linux31428511457:27
🟨​azure windows31428711438:02
💚​gcp linux1528611454:53
💚​gcp windows1528811433:37
8 interesting tests: 4 SKIP, 3 KNOWN, 1 RECOVERED
Test Nameaws linuxaws windowsazure linuxazure windowsgcp linuxgcp windows
💚​TestAccept💚​R💚​R💚​R💚​R💚​R💚​R
🙈​TestAccept/bundle/invariant/no_drift🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🙈​TestAccept/ssh/connection🙈​S🙈​S🙈​S🙈​S🙈​S🙈​S
🟨​TestFetchRepositoryInfoAPI_FromRepo🟨​K🟨​K🟨​K🟨​K🙈​S🙈​S
🟨​TestFetchRepositoryInfoAPI_FromRepo/root🟨​K🟨​K🟨​K🟨​K
🟨​TestFetchRepositoryInfoAPI_FromRepo/subdir🟨​K🟨​K🟨​K🟨​K
Top 3 slowest tests (at least 2 minutes):
durationenvtestname
5:19azure windowsTestAccept
3:26aws windowsTestAccept
3:22gcp windowsTestAccept

TOOLCHAIN: ${{ steps.latest.outputs.toolchain }}
run: |
echo "Bump Go toolchain to ${TOOLCHAIN#go}." \
> ".nextchanges/dependency-updates/go-toolchain-${TOOLCHAIN}.md"

@janniklasrosejanniklasroseAug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denik and I had a chat and we want to start linting nextchanges fragments to require the PR link.

Can we add "Add changelog fragment" after "Create pull requests" so we can include the link?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The snippet in the workflow is speculative... we'll see if it works on the next bump.

Address review feedback: expand the PR link in the 1.26.6 fragment, and
generate future fragments after the PR is created so they can reference
the PR number.
Co-authored-by: Isaac
@pietern
pietern added this pull request to the merge queueAug 14, 2026
Merged via the queue into main with commit 64c673bAug 14, 2026
29 checks passed
@pietern
pietern deleted the go-toolchain-changelog branch August 14, 2026 13:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pietern@eng-dev-ecosystem-bot@janniklasrose