Skip to content

Renamed environments to targets in bundle configuration - #670

Merged
andrewnester merged 8 commits into
mainfrom
env-to-target
Aug 17, 2023
Merged

Renamed environments to targets in bundle configuration#670
andrewnester merged 8 commits into
mainfrom
env-to-target

Conversation

@andrewnester

@andrewnesterandrewnester commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Changes

Renamed Environments to Targets in bundle.yml.

The change is backward-compatible and customers can continue to use environments in the time being.

Tests

Added tests which checks that both environments and targets sections in bundle.yml works correctly

pietern
pietern reviewed Aug 16, 2023
View reviewed changes
Comment threadbundle/config/environment.go Outdated
Comment threadbundle/config/environment.go
Comment threadbundle/config/root.go Outdated
Comment threadbundle/config/root.go Outdated
Comment threadbundle/config/root.go Outdated
Comment threadbundle/tests/environment_git_test.go
Comment threadbundle/tests/environment_git_test.go
Comment threadbundle/tests/environments_job_and_pipeline/databricks.yml
pietern
pietern reviewed Aug 17, 2023
View reviewed changes
Comment threadbundle/config/mutator/select_target.go Outdated
Comment threadbundle/config/root.go Outdated
Comment threadbundle/tests/interpolation_test.go
Comment threadcmd/root/bundle.go Outdated
Comment threadcmd/root/bundle.go
@pieternpietern changed the title Renamed Environments to Targets in bundle.ymlRenamed environments to targets in bundle configurationAug 17, 2023
pietern
pietern reviewed Aug 17, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code under bundle/schema has a few mentions of environments still.

Comment threadbundle/tests/interpolation_test.go
Comment threadcmd/root/bundle.go Outdated
pietern
pietern approved these changes Aug 17, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Please TAL at the schema change before merging.

Comment threadbundle/schema/docs/bundle_descriptions.json Outdated
@andrewnester
andrewnester added this pull request to the merge queueAug 17, 2023
Merged via the queue into main with commit 56dcd3fAug 17, 2023
@andrewnester
andrewnester deleted the env-to-target branch August 17, 2023 15:32
andrewnester added a commit that referenced this pull request Aug 24, 2023
@andrewnester
Release v0.203.2
bb9d7f5
CLI:
* Added `databricks account o-auth-enrollment enable` command ([#687](#687)).
Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined ([#674](#674)).
* Renamed `environments` to `targets` in bundle configuration ([#670](#670)).
* Rename init project-dir flag to output-dir ([#676](#676)).
* Added support for sync.include and sync.exclude sections ([#671](#671)).
* Add template directory flag for bundle templates ([#675](#675)).
* Never ignore root directory when enumerating files in a repository ([#683](#683)).
* Improve 'mode' error message ([#681](#681)).
* Added run_as section for bundle configuration ([#692](#692)).
@andrewnesterandrewnester mentioned this pull request Aug 24, 2023
Merged
github-merge-queueBot pushed a commit that referenced this pull request Aug 24, 2023
@andrewnester
Release v0.203.2 (#694)
c5cd20d
CLI:
* Added `databricks account o-auth-enrollment enable` command
([#687](#687)).
Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([#674](#674)).
* Renamed `environments` to `targets` in bundle configuration
([#670](#670)).
* Rename init project-dir flag to output-dir
([#676](#676)).
* Added support for sync.include and sync.exclude sections
([#671](#671)).
* Add template directory flag for bundle templates
([#675](#675)).
* Never ignore root directory when enumerating files in a repository
([#683](#683)).
* Improve 'mode' error message
([#681](#681)).
* Added run_as section for bundle configuration
([#692](#692)).
arpitjasa-db pushed a commit to arpitjasa-db/cli that referenced this pull request Sep 7, 2023
@andrewnester@arpitjasa-db
Release v0.203.2 (databricks#694)
10e9b2a
CLI:
* Added `databricks account o-auth-enrollment enable` command
([databricks#687](databricks#687)).
Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([databricks#674](databricks#674)).
* Renamed `environments` to `targets` in bundle configuration
([databricks#670](databricks#670)).
* Rename init project-dir flag to output-dir
([databricks#676](databricks#676)).
* Added support for sync.include and sync.exclude sections
([databricks#671](databricks#671)).
* Add template directory flag for bundle templates
([databricks#675](databricks#675)).
* Never ignore root directory when enumerating files in a repository
([databricks#683](databricks#683)).
* Improve 'mode' error message
([databricks#681](databricks#681)).
* Added run_as section for bundle configuration
([databricks#692](databricks#692)).
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
@pieternpietern mentioned this pull request Nov 27, 2024
Merged
github-merge-queueBot pushed a commit that referenced this pull request Nov 27, 2024
@pietern
Update target references to use${bundle.target}(#1935)
fae1b67
## Changes
The built-in template contains a reference to `${bundle.environment}`.
This property has been deprecated in favor of `${bundle.target}` a long
time ago (#670), so we should no longer emit it. The environment field
will continue to be usable until we cut a new major version in some far
away future.
## Tests
* Unit tests
* The test `TestInterpolationWithTarget` still covers correct
interpolation of `${bundle.environment}`
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Renamedenvironmentstotargetsin bundle configuration (#670)
efd3bdc
## Changes
Renamed Environments to Targets in bundle.yml.
The change is backward-compatible and customers can continue to use
`environments` in the time being.
## Tests
Added tests which checks that both `environments` and `targets` sections
in bundle.yml works correctly
denik pushed a commit that referenced this pull request May 20, 2026
@andrewnester
Release v0.203.2 (#694)
862c091
CLI:
* Added `databricks account o-auth-enrollment enable` command
([#687](#687)).
Bundles:
* Do not try auto detect Python package if no Python wheel tasks defined
([#674](#674)).
* Renamed `environments` to `targets` in bundle configuration
([#670](#670)).
* Rename init project-dir flag to output-dir
([#676](#676)).
* Added support for sync.include and sync.exclude sections
([#671](#671)).
* Add template directory flag for bundle templates
([#675](#675)).
* Never ignore root directory when enumerating files in a repository
([#683](#683)).
* Improve 'mode' error message
([#681](#681)).
* Added run_as section for bundle configuration
([#692](#692)).
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Update target references to use${bundle.target}(#1935)
e31e8d5
## Changes
The built-in template contains a reference to `${bundle.environment}`.
This property has been deprecated in favor of `${bundle.target}` a long
time ago (#670), so we should no longer emit it. The environment field
will continue to be usable until we cut a new major version in some far
away future.
## Tests
* Unit tests
* The test `TestInterpolationWithTarget` still covers correct
interpolation of `${bundle.environment}`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes
@shreyas-goenkashreyas-goenkaAwaiting requested review from shreyas-goenka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewnester@pietern