Skip to content

Support Model Serving Endpoints in bundles - #682

Merged
pietern merged 1 commit into
databricks:mainfrom
arpitjasa-db:serving
Sep 7, 2023
Merged

Support Model Serving Endpoints in bundles#682
pietern merged 1 commit into
databricks:mainfrom
arpitjasa-db:serving

Conversation

@arpitjasa-db

@arpitjasa-dbarpitjasa-db commented Aug 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

Add Model Serving Endpoints to Databricks Bundles

Tests

Unit tests and manual testing via https://github.com/databricks/bundle-examples-internal/pull/76
Screenshot 2023-08-28 at 7 46 23 PM
Screenshot 2023-08-28 at 7 47 01 PM

shreyas-goenka
shreyas-goenka reviewed Aug 30, 2023
View reviewed changes
Comment threadbundle/deploy/terraform/convert.go Outdated
shreyas-goenka
shreyas-goenka reviewed Sep 1, 2023
View reviewed changes

@shreyas-goenkashreyas-goenka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks! Just a couple of minor points about additional test coverage needed and we are good to merge.

Comment threadbundle/config/mutator/process_target_mode_test.go
Comment threadbundle/deploy/terraform/convert_test.go
pietern
pietern requested changes Sep 4, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @arpitjasa-db !

The approach LGTM. I'd like to figure out naming consistency before we merge.

Comment threadbundle/config/mutator/process_target_mode_test.go Outdated
Comment threadbundle/schema/openapi.go Outdated
@arpitjasa-db

arpitjasa-db commented Sep 6, 2023

Copy link
Copy Markdown
ContributorAuthor

Confirmed it works as expected here: https://github.com/databricks/bundle-examples-internal/pull/76

pietern
pietern approved these changes Sep 7, 2023
View reviewed changes
Comment threadbundle/config/mutator/process_target_mode_test.go Outdated
Comment threadbundle/schema/openapi.go Outdated
@pieternpietern changed the title Add Model Serving Endpoints to Databricks BundlesAdd Model Serving Endpoints to bundlesSep 7, 2023
@pieternpietern changed the title Add Model Serving Endpoints to bundlesSupport Model Serving Endpoints in bundlesSep 7, 2023
lennartkats-db
lennartkats-db approved these changes Sep 7, 2023
View reviewed changes

@lennartkats-dblennartkats-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really exciting to get serving integrated! Please review the comments re. prefixing

@pietern
pietern enabled auto-merge September 7, 2023 19:52
auto-merge was automatically disabled September 7, 2023 20:22

Head branch was pushed to by a user without write access

@arpitjasa-db
arpitjasa-dbforce-pushed the serving branch 3 times, most recently from 61ee2b1 to d1a9bfcCompareSeptember 7, 2023 20:31
@pietern
pietern enabled auto-merge September 7, 2023 20:38
@arpitjasa-db
Add Model Serving Endpoints to Databricks Bundles
6371364
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
update descriptions
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Fix permissions
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Fix test
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Add test coverage
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Update name and add tests
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Update test
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Fix test
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Add name check to test and fix target
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Fix test
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Update convert_test.go
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Fix nit
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
Update prefix
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
auto-merge was automatically disabled September 7, 2023 21:48

Head branch was pushed to by a user without write access

@pietern
pietern enabled auto-merge September 7, 2023 21:50
@pietern
pietern added this pull request to the merge queueSep 7, 2023
Merged via the queue into databricks:main with commit 50eaf16Sep 7, 2023
@arpitjasa-db
arpitjasa-db deleted the serving branch September 7, 2023 23:03
pietern added a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1
b668c64
Bundles:
* Fix conversion of job parameters ([#744](#744)).
* Add schema and config validation to jsonschema package ([#740](#740)).
* Support Model Serving Endpoints in bundles ([#682](#682)).
* Do not include empty output in job run output ([#749](#749)).
* Fixed marking libraries from DBFS as remote ([#750](#750)).
* Process only Python wheel tasks which have local libraries used ([#751](#751)).
* Add enum support for bundle templates ([#668](#668)).
* Apply Python wheel trampoline if workspace library is used ([#755](#755)).
* List available targets when incorrect target passed ([#756](#756)).
* Make bundle and sync fields optional ([#757](#757)).
* Consolidate environment variable interaction ([#747](#747)).
Internal:
* Update Go SDK to v0.19.1 ([#759](#759)).
@pieternpietern mentioned this pull request Sep 11, 2023
Merged
github-merge-queueBot pushed a commit that referenced this pull request Sep 11, 2023
@pietern
Release v0.204.1 (#763)
44726d6
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).
Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
@pietern@hectorcast-db
Release v0.204.1 (#763)
c05231c
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).
Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
denik pushed a commit that referenced this pull request May 20, 2026
@arpitjasa-db
Support Model Serving Endpoints in bundles (#682)
1b5ee0d
## Changes
<!-- Summary of your changes that are easy to understand -->
Add Model Serving Endpoints to Databricks Bundles
## Tests
<!-- How is this tested? -->
Unit tests and manual testing via
https://github.com/databricks/bundle-examples-internal/pull/76
<img width="1570" alt="Screenshot 2023-08-28 at 7 46 23 PM"
src="https://github.com/databricks/cli/assets/87999496/7030ebd8-b0e2-4ad1-a9e3-5ff8454f1175">
<img width="747" alt="Screenshot 2023-08-28 at 7 47 01 PM"
src="https://github.com/databricks/cli/assets/87999496/fb9b54d7-54e2-43ce-9148-68fb620c809a">
Signed-off-by: Arpit Jasapara <arpit.jasapara@databricks.com>
denik pushed a commit that referenced this pull request May 20, 2026
@pietern
Release v0.204.1 (#763)
920201c
Bundles:
* Fix conversion of job parameters
([#744](#744)).
* Add schema and config validation to jsonschema package
([#740](#740)).
* Support Model Serving Endpoints in bundles
([#682](#682)).
* Do not include empty output in job run output
([#749](#749)).
* Fixed marking libraries from DBFS as remote
([#750](#750)).
* Process only Python wheel tasks which have local libraries used
([#751](#751)).
* Add enum support for bundle templates
([#668](#668)).
* Apply Python wheel trampoline if workspace library is used
([#755](#755)).
* List available targets when incorrect target passed
([#756](#756)).
* Make bundle and sync fields optional
([#757](#757)).
* Consolidate environment variable interaction
([#747](#747)).
Internal:
* Update Go SDK to v0.19.1
([#759](#759)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes
@lennartkats-dblennartkats-dblennartkats-db approved these changes
@shreyas-goenkashreyas-goenkashreyas-goenka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arpitjasa-db@pietern@lennartkats-db@shreyas-goenka