Skip to content

Error when unknown keys are encounters during template execution - #766

Merged
shreyas-goenka merged 10 commits into
mainfrom
error-on-unknown-keys
Sep 14, 2023
Merged

Error when unknown keys are encounters during template execution#766
shreyas-goenka merged 10 commits into
mainfrom
error-on-unknown-keys

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Tests

New unit test and manually

@shreyas-goenka

Copy link
Copy Markdown
ContributorAuthor

End to end error on incorrect key usage:
Screenshot 2023-09-12 at 11 26 03 AM

Comment threadlibs/template/renderer_test.go Outdated

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewnester Please also take a look.

Comment threadlibs/template/renderer.go
Comment threadlibs/template/renderer.go
Comment threadinternal/init_test.go
Comment threadlibs/template/renderer.go

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Final set of comments.

Comment threadlibs/template/renderer.go Outdated
Comment threadinternal/init_test.go
@shreyas-goenka
shreyas-goenka added this pull request to the merge queueSep 14, 2023
Merged via the queue into main with commit 327ab0eSep 14, 2023
@shreyas-goenka
shreyas-goenka deleted the error-on-unknown-keys branch September 14, 2023 15:58
pietern added a commit that referenced this pull request Sep 20, 2023
Bundles:
* Use enums for default python template ([#765](#765)).
* Make bundle deploy work if no resources are defined ([#767](#767)).
* Added support for experimental scripts section ([#632](#632)).
* Error when unknown keys are encounters during template execution ([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported ([#775](#775)).
* Enable environment overrides for job tasks ([#779](#779)).
* Increase timeout waiting for job run to 1 day ([#786](#786)).
Internal:
* Update Go SDK to v0.19.3 (unreleased) ([#778](#778)).
@pieternpietern mentioned this pull request Sep 20, 2023
github-merge-queueBot pushed a commit that referenced this pull request Sep 20, 2023
Bundles:
* Use enums for default python template
([#765](#765)).
* Make bundle deploy work if no resources are defined
([#767](#767)).
* Added support for experimental scripts section
([#632](#632)).
* Error when unknown keys are encounters during template execution
([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported
([#775](#775)).
* Enable environment overrides for job tasks
([#779](#779)).
* Increase timeout waiting for job run to 1 day
([#786](#786)).
Internal:
* Update Go SDK to v0.19.3 (unreleased)
([#778](#778)).
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
hectorcast-db pushed a commit that referenced this pull request Oct 13, 2023
Bundles:
* Use enums for default python template
([#765](#765)).
* Make bundle deploy work if no resources are defined
([#767](#767)).
* Added support for experimental scripts section
([#632](#632)).
* Error when unknown keys are encounters during template execution
([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported
([#775](#775)).
* Enable environment overrides for job tasks
([#779](#779)).
* Increase timeout waiting for job run to 1 day
([#786](#786)).
Internal:
* Update Go SDK to v0.19.3 (unreleased)
([#778](#778)).
denik pushed a commit that referenced this pull request May 20, 2026
denik pushed a commit that referenced this pull request May 20, 2026
Bundles:
* Use enums for default python template
([#765](#765)).
* Make bundle deploy work if no resources are defined
([#767](#767)).
* Added support for experimental scripts section
([#632](#632)).
* Error when unknown keys are encounters during template execution
([#766](#766)).
* Fall back to full Git clone if shallow clone is not supported
([#775](#775)).
* Enable environment overrides for job tasks
([#779](#779)).
* Increase timeout waiting for job run to 1 day
([#786](#786)).
Internal:
* Update Go SDK to v0.19.3 (unreleased)
([#778](#778)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shreyas-goenka@pietern@andrewnester