Skip to content

Make Cobra runner compatible with testing interactive flows - #957

Merged
nfx merged 1 commit into
mainfrom
test/interactive
Nov 7, 2023
Merged

Make Cobra runner compatible with testing interactive flows#957
nfx merged 1 commit into
mainfrom
test/interactive

Conversation

@nfx

@nfxnfx commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

Changes

This PR enables testing commands with stdin

Tests

#914

@nfx
nfx requested a review from pieternNovember 6, 2023 20:35
@nfxnfx mentioned this pull request Nov 6, 2023
@nfxnfx added the Tech Debt Issues related to technical debt (tests, refactoring and etc.) label Nov 7, 2023
@pieternpietern changed the title Make cobra runner compatible with testing interactive flowsMake obra runner compatible with testing interactive flowsNov 7, 2023
@pieternpietern changed the title Make obra runner compatible with testing interactive flowsMake Cobra runner compatible with testing interactive flowsNov 7, 2023
Comment threadinternal/helpers.go
@nfx
nfx added this pull request to the merge queueNov 7, 2023
Merged via the queue into main with commit 56bcb6fNov 7, 2023
@nfx
nfx deleted the test/interactive branch November 7, 2023 19:11
@andrewnesterandrewnester mentioned this pull request Nov 8, 2023
andrewnester added a commit that referenced this pull request Nov 8, 2023
CLI:
* Hide `--progress-format` global flag ([#965](#965)).
* Make configure command visible + fix bundle command description ([#961](#961)).
* Log process ID in each log entry ([#949](#949)).
* Improve error message when `--json` flag is specified ([#933](#933)).
Bundles:
* Remove validation for default value against pattern ([#959](#959)).
* Bundle path rewrites for dbt and SQL file tasks ([#962](#962)).
* Initialize variable definitions that are defined without properties ([#966](#966)).
Internal:
* Remove mention of Lakehouse apps from the changelog ([#945](#945)).
* Function to merge two instances of `config.Value` ([#938](#938)).
* Make to/from string methods private to the jsonschema package ([#942](#942)).
* Make Cobra runner compatible with testing interactive flows ([#957](#957)).
* Added `env.UserHomeDir(ctx)` for parallel-friendly tests ([#955](#955)).
Dependency updates:
* Bump golang.org/x/mod from 0.13.0 to 0.14.0 ([#954](#954)).
* Bump golang.org/x/text from 0.13.0 to 0.14.0 ([#953](#953)).
* Bump golang.org/x/sync from 0.4.0 to 0.5.0 ([#951](#951)).
* Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 ([#950](#950)).
* Bump github.com/fatih/color from 1.15.0 to 1.16.0 ([#952](#952)).
github-merge-queueBot pushed a commit that referenced this pull request Nov 8, 2023
CLI:
* Hide `--progress-format` global flag
([#965](#965)).
* Make configure command visible + fix bundle command description
([#961](#961)).
* Log process ID in each log entry
([#949](#949)).
* Improve error message when `--json` flag is specified
([#933](#933)).
Bundles:
* Remove validation for default value against pattern
([#959](#959)).
* Bundle path rewrites for dbt and SQL file tasks
([#962](#962)).
* Initialize variable definitions that are defined without properties
([#966](#966)).
Internal:
* Function to merge two instances of `config.Value`
([#938](#938)).
* Make to/from string methods private to the jsonschema package
([#942](#942)).
* Make Cobra runner compatible with testing interactive flows
([#957](#957)).
* Added `env.UserHomeDir(ctx)` for parallel-friendly tests
([#955](#955)).
Dependency updates:
* Bump golang.org/x/mod from 0.13.0 to 0.14.0
([#954](#954)).
* Bump golang.org/x/text from 0.13.0 to 0.14.0
([#953](#953)).
* Bump golang.org/x/sync from 0.4.0 to 0.5.0
([#951](#951)).
* Bump github.com/spf13/cobra from 1.7.0 to 1.8.0
([#950](#950)).
* Bump github.com/fatih/color from 1.15.0 to 1.16.0
([#952](#952)).
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
This PR enables testing commands with stdin
## Tests
#914
denik pushed a commit that referenced this pull request May 20, 2026
CLI:
* Hide `--progress-format` global flag
([#965](#965)).
* Make configure command visible + fix bundle command description
([#961](#961)).
* Log process ID in each log entry
([#949](#949)).
* Improve error message when `--json` flag is specified
([#933](#933)).
Bundles:
* Remove validation for default value against pattern
([#959](#959)).
* Bundle path rewrites for dbt and SQL file tasks
([#962](#962)).
* Initialize variable definitions that are defined without properties
([#966](#966)).
Internal:
* Function to merge two instances of `config.Value`
([#938](#938)).
* Make to/from string methods private to the jsonschema package
([#942](#942)).
* Make Cobra runner compatible with testing interactive flows
([#957](#957)).
* Added `env.UserHomeDir(ctx)` for parallel-friendly tests
([#955](#955)).
Dependency updates:
* Bump golang.org/x/mod from 0.13.0 to 0.14.0
([#954](#954)).
* Bump golang.org/x/text from 0.13.0 to 0.14.0
([#953](#953)).
* Bump golang.org/x/sync from 0.4.0 to 0.5.0
([#951](#951)).
* Bump github.com/spf13/cobra from 1.7.0 to 1.8.0
([#950](#950)).
* Bump github.com/fatih/color from 1.15.0 to 1.16.0
([#952](#952)).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tech DebtIssues related to technical debt (tests, refactoring and etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nfx@pietern