Skip to content

Added process stubbing for easier testing of launched subprocesses - #963

Merged
nfx merged 3 commits into
mainfrom
process/stub
Nov 9, 2023
Merged

Added process stubbing for easier testing of launched subprocesses#963
nfx merged 3 commits into
mainfrom
process/stub

Conversation

@nfx

@nfxnfx commented Nov 7, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

This PR makes unit testing with subprocesses fast.

	ctx := context.Background()
ctx, stub := process.WithStub(ctx)
stub.WithDefaultOutput("meeee")
ctx = env.Set(ctx, "FOO", "bar")
out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"})
require.NoError(t, err)
require.Equal(t, "meeee", out)
require.Equal(t, 1, stub.Len())
require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands())
allEnv := stub.CombinedEnvironment()
require.Equal(t, "bar", allEnv["FOO"])
require.Equal(t, "bar", stub.LookupEnv("FOO"))

This should make further iterations of #914 easier

Tests

make test

Serge Smertin
Added ctx, stub := process.WithStub(ctx) for speed of DevEx
1ad3733
This PR makes unit testing with subprocesses fast.
```
ctx := context.Background()
ctx, stub := process.WithStub(ctx)
stub.WithDefaultOutput("meeee")
ctx = env.Set(ctx, "FOO", "bar")
out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"})
require.NoError(t, err)
require.Equal(t, "meeee", out)
require.Equal(t, 1, stub.Len())
require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands())
allEnv := stub.CombinedEnvironment()
require.Equal(t, "bar", allEnv["FOO"])
require.Equal(t, "bar", stub.LookupEnv("FOO"))
```
@nfxnfx added the Tech Debt Issues related to technical debt (tests, refactoring and etc.) label Nov 7, 2023
@nfx
nfx requested a review from pieternNovember 7, 2023 21:51
@nfx
nfx enabled auto-merge November 7, 2023 23:58
pietern
pietern reviewed Nov 8, 2023
View reviewed changes

@pieternpietern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea, but doesn't look finished yet.

Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go Outdated
@nfx
nfx requested a review from pieternNovember 8, 2023 16:37
pietern
pietern reviewed Nov 9, 2023
View reviewed changes
Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go
Comment threadlibs/process/stub.go Outdated
Comment threadlibs/process/stub.go Outdated
@nfx
nfx requested a review from pieternNovember 9, 2023 11:48
pietern
pietern approved these changes Nov 9, 2023
View reviewed changes

@pieternpietern left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Please update title to something more changelog friendly -- e.g.

Add process stubbing for easier testing

@nfx
nfx added this pull request to the merge queueNov 9, 2023
@pietern
pietern removed this pull request from the merge queue due to a manual request Nov 9, 2023
@nfxnfx changed the title Added ctx, stub := process.WithStub(ctx) for speed of DevExAdded process stubbing for easier testing of launched subprocessesNov 9, 2023
@nfx
nfx added this pull request to the merge queueNov 9, 2023
Merged via the queue into main with commit f111b08Nov 9, 2023
@nfx
nfx deleted the process/stub branch November 9, 2023 14:29
denik pushed a commit that referenced this pull request May 20, 2026
@nfx
Added process stubbing for easier testing of launched subprocesses (#963
9aede19
)
## Changes
This PR makes unit testing with subprocesses fast.
```
ctx := context.Background()
ctx, stub := process.WithStub(ctx)
stub.WithDefaultOutput("meeee")
ctx = env.Set(ctx, "FOO", "bar")
out, err := process.Background(ctx, []string{"/usr/local/bin/meeecho", "1", "--foo", "bar"})
require.NoError(t, err)
require.Equal(t, "meeee", out)
require.Equal(t, 1, stub.Len())
require.Equal(t, []string{"meeecho 1 --foo bar"}, stub.Commands())
allEnv := stub.CombinedEnvironment()
require.Equal(t, "bar", allEnv["FOO"])
require.Equal(t, "bar", stub.LookupEnv("FOO"))
```
This should make further iterations of
#914 easier
## Tests
`make test`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pieternpieternpietern approved these changes

Assignees

No one assigned

Labels

Tech DebtIssues related to technical debt (tests, refactoring and etc.)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nfx@pietern